Remove unnecessary null pointer checks before delete/free#56
Open
lumir-sliva wants to merge 6 commits intocern-eos:masterfrom
Open
Remove unnecessary null pointer checks before delete/free#56lumir-sliva wants to merge 6 commits intocern-eos:masterfrom
lumir-sliva wants to merge 6 commits intocern-eos:masterfrom
Conversation
…t is not the current when we are trying to fix. Otherwise, files that have checksum errors and that never update the diskchecksum field, are never recovered.
delete on a null pointer is guaranteed to be a no-op by the C++ standard, and free(NULL) is a no-op per C11 §7.22.3.3. The redundant guards add visual noise without providing any safety benefit. Github-Issue:cern-eos#53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove redundant null pointer checks before
deleteandfree()calls in three locations identified in #53.In C++,
delete nullptris guaranteed to be a no-op by the standard (ISO C++ FAQ). Similarly,free(NULL)is defined as a no-op by the C standard (C11 §7.22.3.3).Changes
fst/xrdcl_plugins/RainFile.cc— Removedif (pFile)andif (pRainFile)guards in theRainFiledestructorfst/http/s3/S3Handler.cc— Removedif (mFile)guard inHandleRequest; thedeleteand subsequent null assignment are preservedauth_plugin/ProtoUtils.cc— Removedif (obj->reqid)andif (obj->notify != nullptr)guards beforefree()inDeleteXrdSfsPrepFixes #53