Plugin(storage::exagrid::snmp): added new mode data-protection and rewrote server-usage mode#6307
Open
mzarza-ssibe wants to merge 1 commit into
Open
Plugin(storage::exagrid::snmp): added new mode data-protection and rewrote server-usage mode#6307mzarza-ssibe wants to merge 1 commit into
mzarza-ssibe wants to merge 1 commit into
Conversation
New functionality Completely rewrote the server-usage mode into a comprehensive monitoring mode with --filter-counters support. Added data-protection mode for monitoring backup health, deduplication, replication, and DR status. Added retention-detail mode for detailed retention space analysis matching the ExaGrid UI. Added support for a broad set of new ExaGrid metrics, including: Server status Landing space available Retention usage Primary and replica retention Pending purge space Deduplication ratio Pending deduplication and replication (size and age) Read, write, and deduplication throughput Improved storage calculations with byte-level precision using whole and fractional SNMP OIDs. Fixed incorrect landing space calculations by replacing the invalid landing-used metric with the vendor-recommended landing-available metric. Fixed retention usage threshold handling so warning and critical thresholds are evaluated correctly. Prevented negative or invalid retention values caused by SNMP rounding. Corrected performance data units for throughput metrics to MB/s. Added support for all required ExaGrid SNMP OIDs to expose the new metrics. Registered the new data-protection and retention-detail modes in the plugin. Optimized SNMP polling using a single table request for all metrics. Maintained compatibility with older Centreon plugin versions without requiring centreon::plugins::constants.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New functionality
Completely rewrote the server-usage mode into a comprehensive monitoring mode with --filter-counters support. Added data-protection mode for monitoring backup health, deduplication, replication, and DR status. Added retention-detail mode for detailed retention space analysis matching the ExaGrid UI. Added support for a broad set of new ExaGrid metrics, including: Server status
Landing space available
Retention usage
Primary and replica retention
Pending purge space
Deduplication ratio
Pending deduplication and replication (size and age) Read, write, and deduplication throughput
Improved storage calculations with byte-level precision using whole and fractional SNMP OIDs. Fixed incorrect landing space calculations by replacing the invalid landing-used metric with the vendor-recommended landing-available metric. Fixed retention usage threshold handling so warning and critical thresholds are evaluated correctly. Prevented negative or invalid retention values caused by SNMP rounding. Corrected performance data units for throughput metrics to MB/s. Added support for all required ExaGrid SNMP OIDs to expose the new metrics. Registered the new data-protection and retention-detail modes in the plugin. Optimized SNMP polling using a single table request for all metrics. Maintained compatibility with older Centreon plugin versions without requiring centreon::plugins::constants.
Community contributors
Description
Please include a short resume of the changes and what is the purpose of this pull request.
Any relevant information should be added to help reviewers to understand what are the stakes
of the pull request.
Fixes # (issue)
If you are fixing a github Issue already existing, mention it here.
Type of change
How this pull request can be tested ?
How this pull request can be tested?
Install the modified ExaGrid plugin.
Run the following modes against an ExaGrid appliance:
server-usage
data-protection
retention-detail
Verify that all counters return valid values and that --filter-counters works as expected for server-usage.
Test warning and critical thresholds on retention-usage.
Verify that:
landing-available matches the "Available for Next Backup" value shown in the ExaGrid UI.
Retention values are reported with byte-level precision.
Throughput metrics are reported in MB/s.
No negative landing or retention values are produced.
Confirm that the plugin works with both recent and older Centreon plugin installations.
Available test data:
ExaGrid SNMP walk of the enterprise branch (.1.3.6.1.4.1.14941).
CLI outputs for all three modes.
ExaGrid MIB used during development.
This is probably enough for a Centreon PR unless they specifically ask you for additional automated tests or sample SNMP walks.
Any relevant details of the configuration to perform the test should be added.
To integrate this pull request into our core we need to add some automated tests to check the proper
functioning of this PR. Ideally we need the following informations:
snmpwalk -ObentU -v 2c -c public address .1.3.6.1.4.1 > equipment.snmpwalk) or SNMP collections.If some information is confidential, such as logins or IP addresses, obfuscate them in what is sent
publicly and we'll get in touch with you by private message if this information is needed.
Checklist
Centreon team (internal PR)
Description
PLEASE MAKE SURE THAT THE BRANCH PR INCLUDES JIRA TICKET ID
Please include a short resume of the changes and what is the purpose of this pull request.
Any relevant information should be added to help reviewers to understand what are the stakes
of the pull request.
Fixes # (issue)
If you are fixing a github Issue already existing, mention it here.
If you are fixing one or more JIRA ticket, mention it here too.
Type of change
How this pull request can be tested ?
Please describe the procedure to verify that the goal of the PR is matched.
Provide clear instructions so that it can be correctly tested.
Mention the automated tests included in this FOR (what they test like mode/option combinations).
Checklist