Skip to content

Upgrade Go to 1.26.5 - #170

Merged
123-komal merged 1 commit into
developfrom
vulnerability-fix
Aug 13, 2026
Merged

Upgrade Go to 1.26.5#170
123-komal merged 1 commit into
developfrom
vulnerability-fix

Conversation

@123-komal

@123-komal 123-komal commented Aug 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Update golang version to 1.26.3

Testing:

  1. Unit Tests: Ran make test using envtest locally, all tests passed successfully.
  2. Build & Push: Successfully built the Docker image locally and pushed it to the Artifact Registry.
  3. Cluster Deployment: Deployed the image and verified all the pods are running state after restart.

Result - The pod was in running state.

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Aug 13, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Go version in go.mod from 1.25.0 to 1.26.3. The reviewer recommended updating the Go version in the Dockerfile to match, which prevents potential build failures or unexpected toolchain downloads.

Comment thread go.mod Outdated
@123-komal 123-komal added the go Pull requests that update go code label Aug 13, 2026
vsethi09
vsethi09 reviewed Aug 13, 2026
View reviewed changes
Comment thread .github/workflows/go.yml Outdated
uses: actions/setup-go@v3
with:
go-version: 1.25
go-version: 1.26.3

@vsethi09 vsethi09 Aug 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.26.5 is the latest stable version.

https://go.dev/dl/

@123-komal 123-komal Aug 13, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

vsethi09
vsethi09 reviewed Aug 13, 2026
View reviewed changes
Comment thread vendor_old/sigs.k8s.io/controller-reconciler/go.mod
@@ -1,6 +1,6 @@
module sigs.k8s.io/controller-reconciler

@vsethi09 vsethi09 Aug 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you run go mod tidy?

@123-komal 123-komal Aug 13, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I ran the command.

@123-komal
123-komal force-pushed the vulnerability-fix branch 2 times, most recently from f6bfa18 to 3ccdff7 Compare August 13, 2026 10:16
@123-komal 123-komal closed this Aug 13, 2026
@123-komal 123-komal reopened this Aug 13, 2026
@123-komal 123-komal changed the title Upgrade Go to 1.26.3 Upgrade Go to 1.26.5 Aug 13, 2026
Komal Yadav
Upgrade Go to 1.26.5
b548c98 
Upgrade Go to 1.26.5
@123-komal
123-komal merged commit b3ce5a5 into develop Aug 13, 2026
10 of 11 checks passed
@123-komal
123-komal deleted the vulnerability-fix branch August 13, 2026 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vsethi09 vsethi09 vsethi09 approved these changes
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

go Pull requests that update go code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@123-komal @vsethi09