feat(request): refactor to thenable handle with lifecycle callbacks#57
Open
cc-hearts wants to merge 1 commit into
Open
feat(request): refactor to thenable handle with lifecycle callbacks#57cc-hearts wants to merge 1 commit into
cc-hearts wants to merge 1 commit into
Conversation
…lbacks - RequestReturn → RequestHandle<T> (thenable + abort()) - Remove .promise — directly awaitable - Remove loading/error/data/aborted fields - Add onSuccess/onError/onAbort/onFinally callbacks - Add timeout, retry, cache, deduplication, download progress - Support Blob/URLSearchParams body, 204/205 response, binary blob - Add 19 new tests, 36 total request tests passing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactor `Request` return type from state object to `RequestHandle` — a thenable that can be directly awaited, with lifecycle callbacks as an alternative API surface.
Breaking changes
New features
Docs
Tests
36 tests total (19 new), all passing.