Fix unused variable warnings#364
Merged
cburstedde merged 1 commit intoMay 22, 2026
Merged
Conversation
hannesbrandt
force-pushed
the
fix-unused-variable-warnings
branch
from
76de8a7 to
5a891d2
Compare
Owner
|
Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix set-but-unused-variable warnings
Proposed changes:
This PR addresses a recent issue in the CI (https://github.com/cburstedde/p4est/actions/runs/26040411092/job/76567611984). There were some set-but-unused-variable warnings for variables that are only used in assertions. This PR removes the warnings by enclosing the variables in an #ifdef P4EST_ENABLE_DEBUG. Also, it updates the submodule to include similar fixes in sc (see cburstedde/libsc#240).