Skip to content

Added support for lifecycle/subplugins.php page#27

Merged
dmitriim merged 2 commits into
MOODLE_401_STABLEfrom
add-get-plugin-name
Mar 6, 2026
Merged

Added support for lifecycle/subplugins.php page#27
dmitriim merged 2 commits into
MOODLE_401_STABLEfrom
add-get-plugin-name

Conversation

@ScottVerbeek

Copy link
Copy Markdown
Member
  • added a get_plugin_name()
  • refactored the get_plugin_description()
  • refactored language pack

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds missing metadata accessors/strings so this lifecycle step can be correctly displayed in the lifecycle subplugins.php UI.

Changes:

  • Introduces get_plugin_name() on the lifecycle step to expose the display name.
  • Refactors get_plugin_description() to use a dedicated plugindescription language string.
  • Updates the English language pack by adding plugindescription and removing the unused description key.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
lang/en/tool_lcbackupcoursestep.php Adds plugindescription string and removes the old description key.
classes/lifecycle/step.php Adds get_plugin_name() and updates get_plugin_description() to use plugindescription.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@owenherbert-catalyst

Copy link
Copy Markdown

Hey @ScottVerbeek , is there a trick I need to use to make the sub plugins visible? I've installed all of the plugins, but only the ones in the base plugin seem to appear.

image

@owenherbert-catalyst
owenherbert-catalyst self-requested a review March 5, 2026 02:19
@ScottVerbeek

Copy link
Copy Markdown
Member Author

Hey Owen this would work with the branch used in : learnweb/moodle-tool_lifecycle#293

@owenherbert-catalyst

Copy link
Copy Markdown

LGTM!

@owenherbert-catalyst

Copy link
Copy Markdown

I've just tested the version bump commit alongside the other sub-plugins and it works as expected.

@dmitriim
dmitriim merged commit 02abd22 into MOODLE_401_STABLE Mar 6, 2026
39 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants