Repository navigation
feat(connections): offer Quack in Add connection - #79
Merged
Merged
Conversation
|
PkgFire: WARN · scan details No dependency changed. 723 packages checked. Why
Listed, not counted
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"Add connection" is where people look first, and Quack was not there: it had its own Attach button in the Remote DuckDB panel. The Connection Type list now offers "Remote DuckDB (Quack)", which closes the sheet and opens the attach sheet. One attach form, two ways in.
QuackAttachmentstakes a bindableattachingprop, so the page can open its sheet; fields reset each time it opens.quack.spec.tsnow skips unless theduckdbCLI can load the quack extension, not just when the CLI is missing. Homebrew's 2.0.0 formula ships a binary that reports a dev build and finds no published extensions, which made the spec fail inbeforeAll.No dependency changes.
Verified
lint, format, typecheck, 1213 unit tests, build (
index306.81 kB), site build. Locally the e2e suite had 38 passed, 2 skipped (Quack, see above) and 6 failed: allliveSession.spec.ts, peers never connect. The same test fails onmainin a clean worktree, so it is not this change; this CI run will show whether it is local to that machine.