Repository navigation
Embed interactive filters work - #71
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Share dialog's Interactive filters rode in the share payload and the embed view never read them, so the docs described a feature that did nothing. The embed now shows a filter bar: a dropdown lists the column's distinct values (up to 500, from the data), a search matches case-insensitively, a range takes numeric min and max; every change re-runs the shared query with the filters wrapped around it as a subquery, so JOINs, CTEs and GROUP BY keep working, and Reset clears them. The filter bar is its own lazily fetched component, so the main bundle stays at 305 kB. Values go through the SQL escaping helpers; LIKE wildcards in a search are escaped. Unit tests for the SQL builder; a Playwright test goes from the Share dialog to the embed URL and checks the dropdown, the range on top of it, and Reset. Docs note the limits.