Skip to content

Embed interactive filters work - #71

Merged
caioricciuti merged 1 commit into
mainfrom
feat/embed-interactive-filters
Oct 2, 2026
Merged

caioricciuti merged 1 commit into
mainfrom
feat/embed-interactive-filters

Conversation

@caioricciuti

Copy link
Copy Markdown
Owner

The Share dialog's Interactive filters rode in the share payload and the embed view never read them, so the docs described a feature that did nothing. The embed now shows a filter bar: a dropdown lists the column's distinct values (up to 500, from the data), a search matches case-insensitively, a range takes numeric min and max; every change re-runs the shared query with the filters wrapped around it as a subquery, so JOINs, CTEs and GROUP BY keep working, and Reset clears them. The filter bar is its own lazily fetched component, so the main bundle stays at 305 kB. Values go through the SQL escaping helpers; LIKE wildcards in a search are escaped. Unit tests for the SQL builder; a Playwright test goes from the Share dialog to the embed URL and checks the dropdown, the range on top of it, and Reset. Docs note the limits.

@caioricciuti
caioricciuti merged commit fb10478 into main Oct 2, 2026
5 of 6 checks passed
@caioricciuti
caioricciuti deleted the feat/embed-interactive-filters branch October 2, 2026 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant