niv ic: update b1fa6ab6 -> 2d17f26d

[dfinity-bot]

Changelog for ic:

Branch: master
Commits: dfinity/ic@b1fa6ab6...2d17f26d

• 0a24c0c1 [BOUN-144] Add port to query logs for a boundary node
• 274e7562 Wait for all endpoints to be ready
• 2d5381fc [ER-1389] [NET-679] Pass the BitcoinPayload builder instead of the NoOpSelfValidatingPayload builder to consensus.
• 11fefc56 Fix sudoers file in generic
• b272bb34 [NNS1-1219] Improve canister_post_upgrade test coverage
• 95360ea2 Port xnet slo test into testing framework
• c9ad3acd Only make new consensus blocks until we have a finalized height that exceeds the upgrade height
• 226fcbbf EXC-1015: Add stable-structures crate
• 13aa5fa5 Improves CUP persistance logs
• 2ecc6194 Update package.lock to new name and version
• a245c0a6 Fix CD pipeline
• 85f12517 [L2-114] address late comments for !2985
• 1b8cac55 [minor] Stabilize the spec compliance test
• a3814ea7 ER-2438: Use the block hashes from the next headers search to discover blocks that need to be cached.
• 29998d1e EXC-1016: An allocator for StableBTreeMap.
• 895c07ea EXC-961: Increase the instruction limit for install_code on verified subnets (2)
• 77f40f0f Remove obsolete rosetta-api README content
• fe71945b Use a single node in nns_backup test
• 68bba688 [ER-2414] Rebrand the ProcessEvent trait into ProcessBitcoinNetworkMessage trait
• b8e7984e No docker builder cache for docker-build-ic
• 29167eda Reorganize PageMap handling in StateManager
• bb201f7e Make rosetta docker image default to non-root user
• 094b7d7a rs/ic_fondue: add support for boundary nodes
• 549a7213 NNS1-1237: Added a small test.
• f840ae65 build: move state manager interface into a separate package
• c96594aa EXC-770 Adjust complexity for 5 system API calls
• c90ec5d4 Extend system-tests nightly with Xnet slo (many subnets)
• 63f316f7 fix mistake with p8s service discovery port reuse
• 6644bfc3 NNS1-1093 - Update comments in governance.proto
• 326fdec4 Add logs and read message retries to basic health test
• 5eedd168 rs/tests: improved the BTC test
• 7d3d143b Take SSL certificates from /boot/config
• 788e54f3 [NET-910][benchmark] Consolidate max-capacity testing
• c87a1ef2 [NET-973] Add existing benchmark topologies to CDMAX.
• 34703fad Address constant-time issues in fe-derive macro output
• 6a00e3c3 NNS1-1078: all proposals use wait for quiet
• 935a4ced Refactoring shared operations between do_remove_nodes and do_remove_node_directly
• 375b533d [NNS1-1092] Add ability to modify the Neuron Permission ACL through manage_neuron canister API
• 4f7a3c3e Enable stack traces for BN executables in the VM logs.
• 0c24a2fd StableBTreeMap: insert and get
• ddf5025a EXC-1013: Refactor get_utxos to avoid copying all utxos of an address.
• ed42cb02 Xnet max capacity benchmark
• 975bb8dd Move all xnet slo tests to system-tests framework
• 8509fc0a CRP-1367: Adding integration tests for IDKG's verify_opening().
• b06a5611 EXC-1018: Propagate AnonymousQueryService down the stack
• 45a99087 Make the stream event channel be responsible only for connection events.
• 8cc2dff8 [MR-186] Remove deprecated requested_to_remove_states_below
• c3e3a518 Add notify endpoints to CMC
• 61917d08 Fix CD scalability max capacity pipeline
• 9440e328 Modify comment
• 982bce23 Add flag to pull dc id from registry
• e92e4aac ER-2478: Remove mutex from blockchain manager to blockchain state
• bfc496b0 Use a BenchmarkArgs structure instead of a tuple
• f58c4d2c Scalability - Reduce xnet test runtime on CI
• 98470175 Revert "Parallelize checkpoint loading in more code paths"
• ecf02c11 Move the transport types into the transport interface
• 6ebe7d3e Let's use the npm of the service worker
• 69e81d28 IngressSelector refactor
• 4a535850 [MR-144] Add reject signals and reroute rejected replies
• d3980ce9 CI job for service-worker
• bf40a35a StableBTreeMap: Minor enhancements
• b3369f5b bump clap version
• 6e67d5ce Change: enforce nix-shell
• 01a9ab6e [ROSETTA1-193] Ledger canister: take into account PERMITTED_DRIFT when pruning
• 66487348 Sync the GRUB file on boot confirmation
• eec0a366 Adds a timeout on image file download
• 7002e70f Change: first build prod-test-driver
• e99b239f [NET-949] Add the shim type that will be used by consensus
• a9a42f3f EXC-1024: StableBTreeMap: remove
• e26b47c5 HTTP request example
• b9e15ebd Change logging level of "aggregate: cannot find selector for content" from ERROR to WARN
• 210e02d4 Moving remove_nodes and add_node into common module
• 8faab30c make canister http adapter client generic
• f2f73ac1 ER-2508: BTC Adapter should only connect to NETWORK flagged nodes.
• 2f540305 Fix: add cleanup of working_tmp_dir
• 159dd9a8 Refactor the hotfix pipeline to fix an invalid CI config
• 371b3866 ER-2509: Move GetSuccessors tests to the new GetSuccessorsHandler
• ba9fd197 [Minor] Increase rosett-pot's ttl to 12 minutes
• 15446af8 [VER-1491] Named Internet Computer in System Tests
• 778552c5 EXC-1036: StableBTreeMap: contains_key, len, is_empty
• e97a790f [NNS1-1147] Integration test for Proposals
• d6f0ad3b Open Governance: Fix typo in expect message for NSP field
• 4cb9e77b Log subnet record at startup
• d3bf0d43 Add gdb to dev icos images
• cde6ac7b EXC-1040: Upgrade Wasmtime to version 0.34.1
• 41196a0d [EXC-890] More efficient input queue reserved slots computation
• c571d359 EXC-1037: StableBTreeMap: Support for iteration.
• 20e42864 Add repo url to package.json
• c3a7e8b3 Ledger canister: Add correct symbol and name
• 66789d18 rs/tests/boundary_nodes_integration: configure nns_public_key and nns_urls
• 635e2038 Add logs into StateManager constructor
• 2091aad2 Use the SubnetId protobuf type in registry
• f63b8061 [NNS1-1075] update comments in SNS governance's canister.rs
• c6d619c9 Ledger: remove post upgrade name and symbol assignment
• 8dfa0007 [Minor] Cleanup suite registration
• d27b90c6 [MR-144] use an enum for certification version type
• 69f47b7d Rewrite Lagrange interpolation code to use NodeIndex instead of EccScalar
• 749d747f CI job for service worker releases
• 0d0c6565 Assume EcdsaSigningSubnetList is empty when missing
• 65236f0b Use ic-build DockerHub image for BD
• ed846171 Got rid of some clippy warnings about lack of use in rs/util/src/fs.rs.
• f01edc33 NNS1-1176: Allow NOs to register new iDKG keys for their existing nodes [override-also-reverse]
• 2b1512f0 NNS1-923: #SNS Call root.change_canister from governance.
• 72bdb10c ECDSA pool persistence (CON-767)
• f31c6cad NNS1-1229: Minimal SNS CLI that can deploy SNS locally
• b4ae7870 NNS1-1146 - Neuron Tests for Claim or Refresh
• d6207302 Separate package for certification version
• ce5c57d6 Bump version for a release to display github link on npm
• 7f2189af Revert "bump clap version" [lessci]
• 8c372731 Remove the dependency on candid for the error_types
• 78ded1b5 Make the internal TxOut::script_pubkey be Vec
• 480f70c6 EXC-1038: Use StableBTreeMap to store UTXOs
• ba1a276e ic-canonical-state compatibility proptests
• 907d1a0f Validate RoutingTable and CanisterIdRanges when decoding
• 1231fdf8 ER-2484: BlockchainManager should clean up expired getdata requests.
• 40be750a Retry if a CUP is not created
• 944670fa remove population of iDKG keys in ic-prep
• 121c0dd2 [NET-971][NET-963][benchmark] Decouple post-processing from benchmark runs.
• bbf0cb98 [VER-1430] Enable uploading/downloading files to/from Farm
• caccc761 [VER-1534] Remove from the basic health test references to the deprecated testing API
• 571ef428 [Cleanup] Remove nns_registry_changes test
• 812e60b7 [OR-77] Upgrade/Downgrade tests
• 2e3311a4 [benchmark] Fix max capacity
• 0b3b694d [NET-975] [NET-968] Don't use nested (deep) protobuf message for communicating between the replica and the adapter.

[nomeata]

This upgrade makes basic-cycles.mo fail. I think the cost for a message has changed significantly recently? (Can't spot it in the commit list above, though)

[nomeata]

Ah, dfinity/ic@4295f3e

[nomeata]

Oh, fun, it seems we are panicing the canister sandbox here:

~/dfinity/motoko/test/run-drun $ ../run.sh -d basic-cycles.mo 
basic-cycles: [tc] [comp] [comp-ref] [valid] [valid-ref] [drun-run] [ic-ref-run]
--- basic-cycles.drun-run.ret (expected)
+++ basic-cycles.drun-run.ret (actual)
@@ -0,0 +1 @@
+Return code 101
--- basic-cycles.drun-run (expected)
+++ basic-cycles.drun-run (actual)
@@ -17,10 +17,7 @@
 debug.print: {added = 18_446_744_073_709_551_615}
 debug.print: {amount = 18_446_744_073_709_551_615; available = 18_446_744_073_709_551_615}
 debug.print: {balance = 18_446_744_073_709_551_615}
-debug.print: {topped_up_balance = 18_446_744_073_709_551_616}
-debug.print: {added = 18_446_744_073_709_551_616}
-debug.print: {amount = 18_446_744_073_709_551_616; available = 18_446_744_073_709_551_616}
-debug.print: {balance = 18_446_744_073_709_551_616}
-debug.print: {topped_up_balance = 18_446_844_073_709_551_616}
-debug.print: can't top up more
-ingress Completed: Reply: 0x4449444c0000
+thread '<unnamed>' panicked at 'Failed to serialize message: ErrorImpl { code: Message("The number can't be stored in CBOR"), offset: 0 }', /build/rs/canister_sandbox/common/src/transport.rs:285:55
+note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
+thread 'MR Batch Processor' panicked at 'Thread pool worker panicked', /build/drun-vendor.tar.gz/scoped_threadpool/src/lib.rs:236:13
+thread 'main' panicked at 'Failed to send batch 26: background worker is dead', messaging/src/message_routing.rs:949:51
Some tests failed:
basic-cycles.mo basic-cycles.mo

I wonder if that’s possible in production as well

[nomeata]

Hmm, it seems to be triggered by passing a very large value to provisional_top_up_canister? But that’s a candid value, I’d be surprised if the canister sandbox transport has to handle that.

[nomeata]

I minimized it to

// test cycle overflow detection and larger cycle transfers

import Prim "mo:⛔";

actor a {

  public func go() : async (){
    // works for 0x1_0000000_000000;
    // works for 0xF000000_000000;
    let amount = 0xFFFFFFFF_00000000;

    Prim.debugPrint("topping up");
    let ic00 = actor "aaaaa-aa" : actor {
      provisional_top_up_canister :
        { canister_id: Principal; amount : Nat } -> async ();
    };
    await ic00.provisional_top_up_canister({
      canister_id = Prim.principalOfActor(a);
      amount = amount});
    Prim.debugPrint("done");
  };
};

a.go(); //OR-CALL ingress go "DIDL\x00\x00"
//SKIP run
//SKIP run-ir

[nomeata]

Moved this discussion to #3105

[mergify]

This bot trusts that bot

[nomeata]

Superseded by #3181