Skip to content

fix: allow regex metacharacters in arguments #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tomholford wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: allow regex metacharacters in arguments #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions grammar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,11 +244,14 @@ module.exports = grammar({
// Comment is available at the start (or during) a line that contains a # with preceding whitespace
comment: _ => token(seq('#', /.*/)),

// Argument is pretty much anything that isn't a matcher
// Argument is pretty much anything that isn't a matcher. Regex
// metacharacters `()[]|?^` are allowed so that `path_regexp`-style
// arguments like `/foo/(bar|baz).*` or `/foo/[0-9]+` lex as a single
// argument token rather than producing an ERROR node.
argument: _ =>
choice(
// Normal arguments without @ or starting with non-@ characters
/[a-zA-Z\-_+.\\\/*:$0-9]([a-zA-Z\-_+.\\\/*:$0-9@]*)/,
/[a-zA-Z\-_+.\\\/*:$0-9(\[?|^][a-zA-Z\-_+.\\\/*:$0-9@()\[\]?|^]*/,

// Arguments starting with @ that contain more @ characters
// (like @longhorn-ui@/share/share/lib/longhorn-ui)
Expand Down
Loading