logging: Add regression coverage for rotated file mode#7620
Merged
steadytao merged 2 commits intocaddyserver:masterfrom Apr 26, 2026
Merged
logging: Add regression coverage for rotated file mode#7620steadytao merged 2 commits intocaddyserver:masterfrom
steadytao merged 2 commits intocaddyserver:masterfrom
Conversation
francislavoie
approved these changes
Apr 25, 2026
Member
francislavoie
left a comment
There was a problem hiding this comment.
LGTM, needs a rebase to fix go.mod then we can merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Caddy-side regression coverage for the log rotation mode issue addressed by the timberjack bump in #7618.
Why
Issue #7613 reported that after log rotation, the new active log file could lose permissions configured via
modebecause the process umask still masked bits during rotation-time file creation.The behavioral fix belongs in
github.com/DeRuina/timberjackand was brought into Caddy by #7618, which bumps timberjack tov1.4.1.This PR does not change Caddy runtime behavior. It adds regression coverage to ensure Caddy’s integration continues to preserve the configured file mode across rotation under a nonzero umask.
What this tests
The new test exercises the user-facing behavior from #7613:
umaskset to002206600660Related
Assistance Disclosure
No AI was used.