added ruff linter and remove few old test cases - #246
Open
AQIB-NAWAB wants to merge 2 commits into
Open
Conversation
Gives a local lint/test baseline for the three services so CI can reuse the same commands. Drops unitTest.py files that still hit old /news routes and the live CSS scraper.
Contributor
Author
|
Hi @hardik1408 , please, I have added linter and validate all test casses. please review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added Ruff linter for api-service, ingestion-service and notification-service. Removed 2 old test files (
unitTest.pyandunitTest_cybernews.py) from monolith. Also added pytest in api-service requirements.Related Issue
#245
Motivation and Context
No linter was there. Old tests were failing on
/newsroute and live scraper which we don't use now.How Has This Been Tested?
Use the
ruff checkcommand in each service to check the linter.and manually running test cases inside each service.
Types of changes
Checklist: