Fix: 404 Error Handler Crash - #171
Open
nikhil1205-ai wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the crash in the error handling system by removing the dependency on g.news_controller and introduces a generic error handler that captures all exceptions and renders a user-friendly HTML error page.
Related Issue
Fixes: #170
Motivation and Context
Previously, the 404 error handler relied on g.news_controller, which may not be initialized when a request hits an invalid route. This caused runtime errors and application crashes.
Additionally, error handling was limited and inconsistent across different types of failures.
This change introduces a centralized error handling mechanism that:
How Has This Been Tested?
Ran the Flask application locally:
flask --app app.py runTested invalid route:
http://127.0.0.1:5000/invalid-routeVerified:
No crash occurs
Tested runtime error scenarios:
Environment:
Screenshots (if appropriate):
Types of changes
Checklist: