fix(functions): add get_functions route and fix wrong endpoint call - #201
Open
alikhere wants to merge 1 commit into
Open
fix(functions): add get_functions route and fix wrong endpoint call#201alikhere wants to merge 1 commit into
alikhere wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
The Functions panel was calling
/get_locals(which runsinfo localsin GDB — local variables of the current stack frame) instead of an endpoint that actually returns program functions. The panel was showing wrong data on every refresh, and there was no/get_functionsroute on the backend at all.Three files changed, all following existing patterns:
POST /get_functionstomain.pyrunninginfo functionsvia GDB, same structure as every other route in the filetest_get_functionstoflask_test.py— backend test count goes from 20 to 21Functions.jsxto call/get_functionsinstead of/get_localsHow to test
Start a debug session with a compiled program, open the Functions panel and trigger a refresh.
info locals(local variable data)info functions(program function list)To verify the backend route directly:
Backend tests:
Related Issue
Fixes #200