Many more component OOM tests#13088
Merged
fitzgen merged 10 commits intobytecodealliance:mainfrom Apr 14, 2026
Merged
Conversation
fitzgen
commented
Apr 14, 2026
Comment on lines
+595
to
+599
| let image = self.engine_code().image(); | ||
| let mut v = Vec::new(); | ||
| v.try_reserve(image.len())?; | ||
| v.extend_from_slice(image); | ||
| Ok(v) |
Member
Author
There was a problem hiding this comment.
Note for reviewers: we aren't using TryVec here because we are returning a Vec in the public API.
Member
There was a problem hiding this comment.
Could this use TryVec and then convert it to a Vec before returning?
alexcrichton
approved these changes
Apr 14, 2026
Comment on lines
+595
to
+599
| let image = self.engine_code().image(); | ||
| let mut v = Vec::new(); | ||
| v.try_reserve(image.len())?; | ||
| v.extend_from_slice(image); | ||
| Ok(v) |
Member
There was a problem hiding this comment.
Could this use TryVec and then convert it to a Vec before returning?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See each commit for details