Skip to content

Add assembly signing #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
YuliiaKovalova wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Add assembly signing #320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4da2ad1
sing a produced assembly with a strong name
YuliiaKovalova Jun 24, 2024
d0e897d
add assemblies signing
YuliiaKovalova Jun 25, 2024
eebdcb0
undo changes in formatting
YuliiaKovalova Jun 25, 2024
e15de25
pull CI changes to have a green build
YuliiaKovalova Jun 25, 2024
4c2685b
remove extra formatting changes
YuliiaKovalova Jun 25, 2024
1cc9328
fix formatting
YuliiaKovalova Jun 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,8 @@ jobs:
# workaround for actions/setup-dotnet#155
- name: Clear package cache
run: dotnet clean Wasmtime.sln && dotnet nuget locals all --clear
- name: Enable development builds for the main branch
if: github.ref == 'refs/heads/main' || github.base_ref == 'main'
- name: Enable development builds for the main branch on schedule
Copy link
Copy Markdown
Contributor

@martindevans martindevans May 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes don't seem to be related to signing. If so please remove them.

if: github.ref == 'refs/heads/main' && github.event_name == 'schedule'
shell: bash
run: |
echo "DevBuild=true" >> $GITHUB_ENV
Expand Down
4 changes: 2 additions & 2 deletions Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project>
<PropertyGroup>
<DevBuild Condition="'$(DevBuild)'==''">true</DevBuild>
<WasmtimeVersion Condition="'$(WasmtimeVersion)'==''">19.0.1</WasmtimeVersion>
<DevBuild Condition="'$(DevBuild)'==''">false</DevBuild>
Copy link
Copy Markdown
Contributor

@martindevans martindevans May 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes don't seem to be related to signing. If so please remove them.

<WasmtimeVersion Condition="'$(WasmtimeVersion)'==''">20.0.2</WasmtimeVersion>
<WasmtimeDotnetVersion Condition="'$(WasmtimeDotnetVersion)'==''"></WasmtimeDotnetVersion>
<WasmtimePackageVersion Condition="'$(DevBuild)'=='true'">$(WasmtimeVersion)$(WasmtimeDotnetVersion)-dev</WasmtimePackageVersion>
<WasmtimePackageVersion Condition="'$(WasmtimePackageVersion)'==''">$(WasmtimeVersion)$(WasmtimeDotnetVersion)</WasmtimePackageVersion>
Expand Down
2 changes: 1 addition & 1 deletion src/AssemblyAttributes.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
using System.Runtime.CompilerServices;

[assembly: InternalsVisibleTo("Wasmtime.Tests")]
[assembly: InternalsVisibleTo("Wasmtime.Tests, PublicKey=0024000004800000940000000602000000240000525341310004000001000100fd9d8818d77c29c70efc6c0c573d0547c68c817daa3367480741c301cbff5faf8e118dbbbaa6d54b5d81232da8f3d94d0de6e957dd712ad5d859497f212f43d92cc16ae545812320b8db34f661c51e254719a1d30c46a13110bd4d7167ebf7119d8fd6f24dcfbcd298ac5806be089cbca5edf9167d28a3c8af3fc08c994972c1")]
Binary file added src/Utils/wasmtime.snk
View file
Open in desktop
Binary file not shown.
2 changes: 2 additions & 0 deletions src/Wasmtime.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,8 @@ The .NET embedding of Wasmtime enables .NET code to instantiate WebAssembly modu
<ReleaseURLBase Condition="'$(ReleaseURLBase)'==''">$(BaseURL)/v$(WasmtimeVersion)</ReleaseURLBase>
<ReleaseFileNameBase Condition="'$(DevBuild)'=='true'">wasmtime-dev</ReleaseFileNameBase>
<ReleaseFileNameBase Condition="'$(ReleaseFileNameBase)'==''">wasmtime-v$(WasmtimeVersion)</ReleaseFileNameBase>
<SignAssembly>True</SignAssembly>
<AssemblyOriginatorKeyFile>Utils\wasmtime.snk</AssemblyOriginatorKeyFile>
</PropertyGroup>

<ItemGroup>
Expand Down
Binary file added tests/Utils/wasmtime.tests.snk
View file
Open in desktop
Binary file not shown.
5 changes: 5 additions & 0 deletions tests/Wasmtime.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,11 @@
</PackageReference>
</ItemGroup>

<PropertyGroup>
<SignAssembly>true</SignAssembly>
<AssemblyOriginatorKeyFile>Utils\wasmtime.tests.snk</AssemblyOriginatorKeyFile>
</PropertyGroup>

<ItemGroup>
<ProjectReference Include="..\src\Wasmtime.csproj" />
</ItemGroup>
Expand Down