Skip to content

fix: use btcutil.DecodeAddress for Bitcoin address validation #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vwinee21 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: use btcutil.DecodeAddress for Bitcoin address validation #129

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 7 additions & 24 deletions spark/so/utils/btc_address_network.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,34 +1,17 @@
package utils

import (
"strings"

"github.com/btcsuite/btcd/btcutil"
"github.com/lightsparkdev/spark/common/btcnetwork"
)

// IsBitcoinAddressForNetwork checks if the given Bitcoin address matches the expected prefix for the specified network.
// It uses simple prefix matching for common address types (legacy, P2SH, SegWit, Taproot) for each Bitcoin network.
// TODO: Investigate using btcutil for this instead of using our own.
// IsBitcoinAddressForNetwork checks if the given Bitcoin address is valid for the specified network.
// It uses btcutil.DecodeAddress for proper address validation including checksum verification.
func IsBitcoinAddressForNetwork(address string, network btcnetwork.Network) bool {
switch network {
case btcnetwork.Mainnet:
return hasAnyPrefix(address, "bc1", "3", "1")
case btcnetwork.Regtest:
return hasAnyPrefix(address, "bcrt", "2", "m", "n")
case btcnetwork.Testnet:
return hasAnyPrefix(address, "tb1", "2", "m", "n")
case btcnetwork.Signet:
return hasAnyPrefix(address, "tb1", "sb1", "2", "m", "n")
default:
params, err := network.Params()
if err != nil {
return false
}
}

func hasAnyPrefix(address string, prefixes ...string) bool {
for _, prefix := range prefixes {
if strings.HasPrefix(address, prefix) {
return true
}
}
return false
_, err = btcutil.DecodeAddress(address, params)
return err == nil
}