Skip to content

cli.js --> cli.mjs #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hirokuma wants to merge 1 commit into
base: main
Choose a base branch
from
Open

cli.js --> cli.mjs #115

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdks/js/apps/spark-cli/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"description": "Spark CLI",
"type": "module",
"bin": {
"spark-cli": "./dist/cli.js"
"spark-cli": "./dist/cli.mjs"

@cursor cursor Bot Apr 22, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bin entry points to non-existent output file

High Severity

The bin entry now references ./dist/cli.mjs, but tsdown with format: ["esm"] produces ./dist/cli.js when "type": "module" is set in package.json. The .mjs extension is only used when "type": "module" is absent. Since the package keeps "type": "module", the built output will still be cli.js, and the bin link will point to a non-existent file — the CLI remains broken with the same spark-cli: command not found error this PR aims to fix.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 9e44ac5. Configure here.

@hirokuma hirokuma Apr 22, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, the file actually included in the package is dist/cli.mjs.
https://app.unpkg.com/@buildonspark/cli@0.0.121/files/dist/cli.mjs

},
"files": [
"dist",
Expand Down