fix(release): drop the deleted @uploads/workspace from changesets ignore#523
Merged
Merged
Conversation
#522 deleted packages/workspace but left it in .changeset/config.json's ignore list. Changesets validates that every ignored entry resolves to a real package, so `changeset version` now fails config parsing before it does any work — blocking the release PR and every npm publish behind it. Removing the stale entry restores it. `changeset status` confirms the pending @buildinternet/uploads minor is intact, so nothing was lost; the release PR regenerates on the next run. Checked the remaining five ignore entries against the actual workspace list — all resolve.
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (2)
🚫 Excluded labels (none allowed) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unblocks the release pipeline on
main. Follow-up to #522.#522 deleted
packages/workspace, but left"@uploads/workspace"in.changeset/config.json'signorearray. Changesets validates that every ignored entry resolves to a real package, sochangeset versionnow fails during config parsing — before it does any work:That blocks the release PR and every npm publish behind it. My miss on #522: I checked the ignore list to confirm the published package wasn't in it, and didn't consider that deleting a package invalidates its entry.
Verification
changeset statuspasses and the pending changeset is intact — nothing was lost, the release PR regenerates on the next run:Also checked the remaining five ignore entries against the actual workspace list; all resolve.
No changeset here — this is release config only and changes nothing about the published package.