-
Notifications
You must be signed in to change notification settings - Fork 182
test: expand coverage for core utilities, providers, and error handling #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
devhimanshuu
wants to merge
2
commits into
bug0inc:main
Choose a base branch
from
devhimanshuu:test_coverage
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| import { describe, it, expect } from "vitest"; | ||
| import { | ||
| PassmarkError, | ||
| StepExecutionError, | ||
| AIModelError, | ||
| CacheError, | ||
| ConfigurationError, | ||
| ValidationError, | ||
| } from "../errors"; | ||
|
|
||
| describe("Custom Errors", () => { | ||
| it("PassmarkError creates correct properties", () => { | ||
| const err = new PassmarkError("base error", "BASE_CODE"); | ||
| expect(err).toBeInstanceOf(Error); | ||
| expect(err.name).toBe("PassmarkError"); | ||
| expect(err.message).toBe("base error"); | ||
| expect(err.code).toBe("BASE_CODE"); | ||
| }); | ||
|
|
||
| it("StepExecutionError creates correct properties", () => { | ||
| const err = new StepExecutionError("step failed", "my step"); | ||
| expect(err).toBeInstanceOf(PassmarkError); | ||
| expect(err.name).toBe("StepExecutionError"); | ||
| expect(err.message).toBe("step failed"); | ||
| expect(err.code).toBe("STEP_EXECUTION_FAILED"); | ||
| expect(err.stepDescription).toBe("my step"); | ||
| }); | ||
|
|
||
| it("AIModelError creates correct properties", () => { | ||
| const err = new AIModelError("ai failed"); | ||
| expect(err).toBeInstanceOf(PassmarkError); | ||
| expect(err.name).toBe("AIModelError"); | ||
| expect(err.message).toBe("ai failed"); | ||
| expect(err.code).toBe("AI_MODEL_ERROR"); | ||
| }); | ||
|
|
||
| it("CacheError creates correct properties", () => { | ||
| const err = new CacheError("cache miss"); | ||
| expect(err).toBeInstanceOf(PassmarkError); | ||
| expect(err.name).toBe("CacheError"); | ||
| expect(err.message).toBe("cache miss"); | ||
| expect(err.code).toBe("CACHE_ERROR"); | ||
| }); | ||
|
|
||
| it("ConfigurationError creates correct properties", () => { | ||
| const err = new ConfigurationError("missing key"); | ||
| expect(err).toBeInstanceOf(PassmarkError); | ||
| expect(err.name).toBe("ConfigurationError"); | ||
| expect(err.message).toBe("missing key"); | ||
| expect(err.code).toBe("CONFIGURATION_ERROR"); | ||
| }); | ||
|
|
||
| it("ValidationError creates correct properties", () => { | ||
| const err = new ValidationError("invalid input"); | ||
| expect(err).toBeInstanceOf(PassmarkError); | ||
| expect(err.name).toBe("ValidationError"); | ||
| expect(err.message).toBe("invalid input"); | ||
| expect(err.code).toBe("VALIDATION_ERROR"); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,95 @@ | ||
| import { describe, it, expect, vi, beforeEach, afterEach } from "vitest"; | ||
| import { emailsinkProvider } from "../../providers/emailsink"; | ||
|
|
||
| describe("emailsinkProvider", () => { | ||
| const originalFetch = global.fetch; | ||
|
|
||
| beforeEach(() => { | ||
| global.fetch = vi.fn(); | ||
| }); | ||
|
|
||
| afterEach(() => { | ||
| global.fetch = originalFetch; | ||
| vi.restoreAllMocks(); | ||
| }); | ||
|
|
||
| it("returns a provider with correct domain", () => { | ||
| const provider = emailsinkProvider({}); | ||
| expect(provider.domain).toBe("emailsink.dev"); | ||
| }); | ||
|
|
||
| it("extracts content successfully without api key", async () => { | ||
| const mockResponse = { result: "123456" }; | ||
| (global.fetch as any).mockResolvedValueOnce({ | ||
| json: vi.fn().mockResolvedValueOnce(mockResponse), | ||
| }); | ||
|
|
||
| const provider = emailsinkProvider({}); | ||
| const content = await provider.extractContent({ | ||
| email: "test@emailsink.dev", | ||
| prompt: "get code", | ||
| }); | ||
|
|
||
| expect(global.fetch).toHaveBeenCalledWith( | ||
| "https://get.emailsink.dev/?email=test%40emailsink.dev&prompt=get%20code" | ||
| ); | ||
| expect(content).toBe("123456"); | ||
| }); | ||
|
|
||
| it("extracts content successfully with api key", async () => { | ||
| const mockResponse = { result: "654321" }; | ||
| (global.fetch as any).mockResolvedValueOnce({ | ||
| json: vi.fn().mockResolvedValueOnce(mockResponse), | ||
| }); | ||
|
|
||
| const provider = emailsinkProvider({ apiKey: "my-secret-key" }); | ||
| const content = await provider.extractContent({ | ||
| email: "test2@emailsink.dev", | ||
| prompt: "get otp", | ||
| }); | ||
|
|
||
| expect(global.fetch).toHaveBeenCalledWith( | ||
| "https://get.emailsink.dev/?email=test2%40emailsink.dev&prompt=get%20otp&secret=my-secret-key" | ||
| ); | ||
| expect(content).toBe("654321"); | ||
| }); | ||
|
|
||
| it("handles stringified json result", async () => { | ||
| const mockResponse = { result: '{"result":"parsed-code"}' }; | ||
| (global.fetch as any).mockResolvedValueOnce({ | ||
| json: vi.fn().mockResolvedValueOnce(mockResponse), | ||
| }); | ||
|
|
||
| const provider = emailsinkProvider({}); | ||
| const content = await provider.extractContent({ | ||
| email: "test@emailsink.dev", | ||
| prompt: "get code", | ||
| }); | ||
|
|
||
| expect(content).toBe("parsed-code"); | ||
| }); | ||
|
|
||
| it("throws error when result is undefined", async () => { | ||
| const mockResponse = {}; // no result | ||
| (global.fetch as any).mockResolvedValueOnce({ | ||
| json: vi.fn().mockResolvedValueOnce(mockResponse), | ||
| }); | ||
|
|
||
| const provider = emailsinkProvider({}); | ||
| await expect( | ||
| provider.extractContent({ email: "test@emailsink.dev", prompt: "code" }) | ||
| ).rejects.toThrow("No email content found"); | ||
| }); | ||
|
|
||
| it("throws error when result is empty string", async () => { | ||
| const mockResponse = { result: "" }; | ||
| (global.fetch as any).mockResolvedValueOnce({ | ||
| json: vi.fn().mockResolvedValueOnce(mockResponse), | ||
| }); | ||
|
|
||
| const provider = emailsinkProvider({}); | ||
| await expect( | ||
| provider.extractContent({ email: "test@emailsink.dev", prompt: "code" }) | ||
| ).rejects.toThrow("No email content found"); | ||
| }); | ||
| }); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.