BTI-1342-PrestaShop-Remove-GoSettle-as-payment-method-deprecated

README.md

@@ -90,12 +90,12 @@ The module supports the following payment methods. Each one can be enabled or di
 | [Alipay](https://docs.buckaroo.io/docs/alipay) | [Apple Pay](https://docs.buckaroo.io/docs/apple-pay) | [Bancontact](https://docs.buckaroo.io/docs/bancontact) |
 | [Bank Transfer](https://docs.buckaroo.io/docs/transfer) | [Belfius](https://docs.buckaroo.io/docs/belfius) | [Billink](https://docs.buckaroo.io/docs/billink) |
 | [Bizum](https://docs.buckaroo.io/docs/bizum) | [Blik](https://docs.buckaroo.io/docs/blik) | [Credit and debit cards](https://docs.buckaroo.io/docs/creditcards) |
-| [EPS](https://docs.buckaroo.io/docs/eps) | [Giftcards](https://docs.buckaroo.io/docs/giftcards) | [GoSettle](https://docs.buckaroo.io/docs/gosettle) |
-| [iDEAL / Wero](https://docs.buckaroo.io/docs/ideal) | [In3](https://docs.buckaroo.io/docs/in3) | [KBC](https://docs.buckaroo.io/docs/kbc) |
-| [MB Way](https://docs.buckaroo.io/docs/mb-way) | [Multibanco](https://docs.buckaroo.io/docs/multibanco) | [Pay by Bank](https://docs.buckaroo.io/docs/pay-by-bank) |
-| [PayPal](https://docs.buckaroo.io/docs/paypal) | [PayPerEmail](https://docs.buckaroo.io/docs/payperemail) | [Przelewy24](https://docs.buckaroo.io/docs/przelewy24) |
-| [Riverty](https://docs.buckaroo.io/docs/riverty) | [Swish](https://docs.buckaroo.io/docs/swish) | [Trustly](https://docs.buckaroo.io/docs/trustly) |
-| [Twint](https://docs.buckaroo.io/docs/twint) | [WeChatPay](https://docs.buckaroo.io/docs/wechatpay) | [Wero](https://docs.buckaroo.io/docs/wero) |
+| [EPS](https://docs.buckaroo.io/docs/eps) | [Giftcards](https://docs.buckaroo.io/docs/giftcards) | [iDEAL / Wero](https://docs.buckaroo.io/docs/ideal) |
+| [In3](https://docs.buckaroo.io/docs/in3) | [KBC](https://docs.buckaroo.io/docs/kbc) | [MB Way](https://docs.buckaroo.io/docs/mb-way) |
+| [Multibanco](https://docs.buckaroo.io/docs/multibanco) | [Pay by Bank](https://docs.buckaroo.io/docs/pay-by-bank) | [PayPal](https://docs.buckaroo.io/docs/paypal) |
+| [PayPerEmail](https://docs.buckaroo.io/docs/payperemail) | [Przelewy24](https://docs.buckaroo.io/docs/przelewy24) | [Riverty](https://docs.buckaroo.io/docs/riverty) |
+| [Swish](https://docs.buckaroo.io/docs/swish) | [Trustly](https://docs.buckaroo.io/docs/trustly) | [Twint](https://docs.buckaroo.io/docs/twint) |
+| [WeChatPay](https://docs.buckaroo.io/docs/wechatpay) | [Wero](https://docs.buckaroo.io/docs/wero) | |
 
 > [!IMPORTANT]
 > All supported methods appear in the PrestaShop backend, but you need an active Buckaroo subscription for a method before you can offer it in your checkout.

api/paymentmethods/paymentrequestfactory.php

@@ -49,7 +49,6 @@ class PaymentRequestFactory
     public const REQUEST_TYPE_ALIPAY = 'alipay';
     public const REQUEST_TYPE_MULTIBANCO = 'multibanco';
     public const REQUEST_TYPE_MBWAY = 'mbway';
-    public const REQUEST_TYPE_KNAKEN = 'knaken';
     public const REQUEST_TYPE_TWINT = 'twint';
     public const REQUEST_TYPE_SWISH = 'swish';
     public const REQUEST_TYPE_BIZUM = 'bizum';
@@ -85,7 +84,6 @@ class PaymentRequestFactory
         PaymentRequestFactory::REQUEST_TYPE_ALIPAY => 'Alipay',
         PaymentRequestFactory::REQUEST_TYPE_MULTIBANCO => 'Multibanco',
         PaymentRequestFactory::REQUEST_TYPE_MBWAY => 'Mbway',
-        PaymentRequestFactory::REQUEST_TYPE_KNAKEN => 'Knaken',
         PaymentRequestFactory::REQUEST_TYPE_TWINT => 'Twint',
         PaymentRequestFactory::REQUEST_TYPE_SWISH => 'Swish',
         PaymentRequestFactory::REQUEST_TYPE_BIZUM => 'Bizum',

dev/lang/php_de.json

@@ -202,7 +202,6 @@
   "payment_methods.bizum": "Bizum",
   "payment_methods.wero": "Wero",
   "payment_methods.wechatpay": "WeChatPay",
-  "payment_methods.knaken": "goSettle",
   "verification_methods.idin": "iDIN",
   "dashboard.pages.payments.displayInCheckout": "Marken-Gruppierung im Checkout",
   "dashboard.pages.payments.displayInCheckoutDesc": "Option, wie Marken im Checkout angezeigt werden sollen. <br/> <b>Separate</b>: Marken werden im Checkout separat angezeigt.</br><b>Grouped</b>: Marken werden innerhalb einer Gruppe angezeigt."

dev/lang/php_en.json

@@ -207,7 +207,6 @@
   "payment_methods.bizum": "Bizum",
   "payment_methods.wero": "Wero",
   "payment_methods.wechatpay": "WeChatPay",
-  "payment_methods.knaken": "goSettle",
   "verification_methods.idin": "iDIN",
   "dashboard.pages.payments.displayInCheckout": "Group brands in checkout",
   "dashboard.pages.payments.displayInCheckoutDesc": "Option for how to show brands in the checkout. <br/> <b>Separate</b>: Brands are shown separately in the checkout.</br><b>Grouped</b>: Brands are shown within one group."

dev/lang/php_fr.json

@@ -202,7 +202,6 @@
   "payment_methods.bizum": "Bizum",
   "payment_methods.wero": "Wero",
   "payment_methods.wechatpay": "WeChatPay",
-  "payment_methods.knaken": "goSettle",
   "verification_methods.idin": "IDIN",
   "dashboard.pages.payments.displayInCheckout": "Regroupement des marques au paiement",
   "dashboard.pages.payments.displayInCheckoutDesc": "Option pour définir la façon dont les marques sont affichées lors du paiement. <br/> <b>Separate</b> : Les marques sont affichées séparément lors du paiement.</br><b>Grouped</b> : Les marques sont affichées dans un seul groupe."

dev/lang/php_nl.json

@@ -198,7 +198,6 @@
   "payment_methods.bizum": "Bizum",
   "payment_methods.wero": "Wero",
   "payment_methods.wechatpay": "WeChatPay",
-  "payment_methods.knaken": "goSettle",
   "verification_methods.idin": "iDIN",
   "dashboard.pages.payments.displayInCheckout": "Groepering van merken in checkout",
   "dashboard.pages.payments.displayInCheckoutDesc": "Optie om te bepalen hoe merken in de checkout worden getoond. <br/> <b>Separate</b>: Merken worden afzonderlijk in de checkout getoond.</br><b>Grouped</b>: Merken worden binnen één groep getoond."

library/checkout/checkout.php

@@ -57,7 +57,6 @@ abstract class Checkout
     public const CHECKOUT_TYPE_ALIPAY = 'alipay';
     public const CHECKOUT_TYPE_MBWAY = 'mbway';
     public const CHECKOUT_TYPE_MULTIBANCO = 'multibanco';
-    public const CHECKOUT_TYPE_KNAKEN = 'knaken';
     public const CHECKOUT_TYPE_BLIK = 'blik';
     public const CHECKOUT_TYPE_TWINT = 'twint';
     public const CHECKOUT_TYPE_SWISH = 'swish';
@@ -92,7 +91,6 @@ abstract class Checkout
         self::CHECKOUT_TYPE_ALIPAY => 'Alipay',
         self::CHECKOUT_TYPE_MBWAY => 'Mbway',
         self::CHECKOUT_TYPE_MULTIBANCO => 'Multibanco',
-        self::CHECKOUT_TYPE_KNAKEN => 'Knaken',
         self::CHECKOUT_TYPE_BLIK => 'Blik',
         self::CHECKOUT_TYPE_TWINT => 'Twint',
         self::CHECKOUT_TYPE_SWISH => 'Swish',

src/Repository/RawPaymentMethodRepository.php

@@ -147,7 +147,6 @@ private function getPaymentMethodsData()
             ['name' => 'swish', 'label' => 'Swish', 'icon' => 'Swish.svg', 'template' => '', 'is_payment_method' => '1'],
             ['name' => 'bizum', 'label' => 'Bizum', 'icon' => 'Bizum.svg', 'template' => '', 'is_payment_method' => '1'],
             ['name' => 'wero', 'label' => 'Wero', 'icon' => 'Wero.svg', 'template' => '', 'is_payment_method' => '1'],
-            ['name' => 'knaken', 'label' => 'goSettle', 'icon' => 'GoSettle.svg', 'template' => '', 'is_payment_method' => '1'],
         ];
     }
 

upgrade/upgrade-4.4.0.php

@@ -45,7 +45,7 @@ function upgrade_module_4_4_0($object)
 
     $paymentMethodId = Db::getInstance()->Insert_ID();
 
-    // Insert default configuration for Knaken Settle
+    // Insert default configuration for Blik
     $blikConfig = [
         'mode' => 'off'
     ];

upgrade/upgrade-5.3.0.php

@@ -0,0 +1,75 @@
+<?php
+/**
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Academic Free License (AFL 3.0)
+ * It is available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/afl-3.0.php
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade this file
+ *
+ *  @author    Buckaroo.nl <plugins@buckaroo.nl>
+ *  @copyright Copyright (c) Buckaroo B.V.
+ *  @license   http://opensource.org/licenses/afl-3.0.php  Academic Free License (AFL 3.0)
+ */
+
+if (!defined('_PS_VERSION_')) {
+    exit;
+}
+
+/**
+ * Removes the GoSettle (knaken) payment method from existing installations.
+ *
+ * @param object $object Module instance
+ *
+ * @return bool
+ */
+function upgrade_module_5_2_1($object)
+{
+    $db = Db::getInstance();
+
+    $sql = new DbQuery();
+    $sql->select('id');
+    $sql->from('bk_payment_methods');
+    $sql->where('name = "knaken"');
+
+    $paymentMethodId = (int) $db->getValue($sql);
+
+    if ($paymentMethodId > 0) {
+        $db->execute(
+            'DELETE FROM `' . _DB_PREFIX_ . 'bk_configuration` WHERE configurable_id = ' . $paymentMethodId
+        );
+
+        $orderings = $db->executeS('SELECT id, value FROM `' . _DB_PREFIX_ . 'bk_ordering`');
+        if (is_array($orderings)) {
+            foreach ($orderings as $row) {
+                $ids = json_decode($row['value'], true);
+                if (!is_array($ids)) {
+                    continue;
+                }
+
+                $filtered = array_values(array_filter($ids, function ($id) use ($paymentMethodId) {
+                    return (int) $id !== $paymentMethodId;
+                }));
+
+                $db->update(
+                    'bk_ordering',
+                    [
+                        'value' => pSQL(json_encode($filtered)),
+                    ],
+                    'id = ' . (int) $row['id']
+                );
+            }
+        }
+
+        $db->execute(
+            'DELETE FROM `' . _DB_PREFIX_ . 'bk_payment_methods` WHERE id = ' . $paymentMethodId
+        );
+    }
+
+    $db->execute('DELETE FROM `' . _DB_PREFIX_ . 'bk_payment_methods` WHERE name = "knaken"');
+
+    return true;
+}