[pull] main from goauthentik:main - #142
Merged
Merged
Conversation
User.locale() returned request.LANGUAGE_CODE before consulting the user's own attributes.settings.locale, so a user's saved preference was shadowed whenever LocaleMiddleware resolved anything (which is always). Return the saved locale first when set and non-empty, falling back to request.LANGUAGE_CODE. Also drop the dead trailing branch referencing request.brand.locale, a property that does not exist (it is default_locale, and brand fallback is already handled by BrandMiddleware). Co-authored-by: Teffen Ellis <teffen@Teffens-MacBook-Pro.local>
* web: Add router-core cross-interface href builders. * web: Add router-core navigation and click interception. * web: Let the browser own fragment-only navigations. Hash-only (`#section`) and same-URL clicks resolve to the current path and query, differing at most by fragment. The interceptor now falls through to native handling for these, restoring fragment scroll and native reload instead of claiming them as dead in-app navigations. * web: Add legacy hash-route redirect shim. * web: Wire urlpattern-polyfill into the polyfill bundle. * web: Deduplicate interface prefix construction. The href builders, click interceptor, and hash shim each built the base-plus-interface prefix independently. formatInterfacePrefix is now the single source, with a direct test pinning the base-without-trailing- slash case. * web: Fix formatting and spelling in the navigation layer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )