Add sign_digest_less_safe to rsa KeyPair#1493
Closed
ldufr wants to merge 1 commit intobriansmith:mainfrom
Closed
Conversation
A user of the library can leverage this new function to sign a digest without having all the message at once. I agree to license my contributions to each file under the terms given at the top of each file I changed.
Closed
Author
|
Closed since no reaction and don't want to maintain the branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of this MR is to allow a user to sign a digest without having to have all the message at disposition. I tried to follow the advises given in MR-915, for instance the name of the function.
In addition, I'm not convince the testing code I added is the best or most elegant way to do it, but I didn't want to add custom stuff to support testing. Arguably, it's a little awkward to specify the digest algorithm twice. You might have some recommendation on that.