Use non-zero value when initializing test buffers#1157
Open
caio wants to merge 1 commit intobriansmith:mainfrom
caio:issue_128
Open
Use non-zero value when initializing test buffers#1157caio wants to merge 1 commit intobriansmith:mainfrom caio:issue_128
caio wants to merge 1 commit intobriansmith:mainfrom
caio:issue_128
Conversation
Author
|
Force-pushed an update to the branch due to a failed |
Codecov Report
@@ Coverage Diff @@
## main #1157 +/- ##
==========================================
- Coverage 93.69% 91.92% -1.78%
==========================================
Files 115 106 -9
Lines 17462 14248 -3214
==========================================
- Hits 16361 13097 -3264
- Misses 1101 1151 +50
Continue to review full report at Codecov.
|
I agree to license my contributions to each file under the terms given at the top of each file I changed. Closes #128
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
Picking up from PRs #564 and #600:
UNINITIALIZED_U8withvalue
0xDEI tried to find every candidate in
tests/and found a few tests frominside
src/too.And I've opted to leave the buffers from
max_input_tests!insrc/digest.rsuntouched as they are about the input length, but let meknow if you prefer otherwise.
Aside: the README recommends running
cargo test --no-default-featuresprior to a PR but it fails to compile for me (Windows, WSL2 with Ubuntu
20.04) because the
test_file!macro is gated by theallocfeature.Running
cargo test --no-default-features --features allocworks fine.