StaticKeyPair in agreement module#1081
Open
richard-w wants to merge 3 commits intobriansmith:mainfrom
Open
Conversation
`agreement_agree_ephemeral` still tests the ephemeral key agreement. The public key tests have been moved to `agreement_public_key`.
In contrast to `EphemeralPrivateKey` a `StaticKeyPair` can be used multiple times.
Author
|
The test failure is a spurious error in appveyor. |
richard-w
force-pushed
the
feature/agreement-static-key
branch
from
453c6cc to
5282885
Compare
richard-w
force-pushed
the
feature/agreement-static-key
branch
from
97eb7f5 to
d151810
Compare
Codecov Report
@@ Coverage Diff @@
## main #1081 +/- ##
==========================================
+ Coverage 91.97% 92.01% +0.03%
==========================================
Files 106 106
Lines 14238 14395 +157
==========================================
+ Hits 13096 13246 +150
- Misses 1142 1149 +7
Continue to review full report at Codecov.
|
richard-w
force-pushed
the
feature/agreement-static-key
branch
from
d151810 to
0da2432
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
agreement::StaticKeyPairandagreement::agree_staticAlso restructures some existing tests to avoid duplication of code and test vectors.
Closes: #331