Skip to content

Tuckute2024 Benchmark Fix#405

Merged
KartikP merged 11 commits into
brain-score:mainfrom
BKHMSI:tuckute2024-fix
Jun 6, 2026
Merged

Tuckute2024 Benchmark Fix#405
KartikP merged 11 commits into
brain-score:mainfrom
BKHMSI:tuckute2024-fix

Conversation

@BKHMSI

@BKHMSI BKHMSI commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

Summary

  • The tuckute2024 benchmark triggers a case where predicted_values is 1D (shape (n,)) when there is a single target neuroid, causing NeuroidAssembly construction to fail on dimension/coord mismatch.
  • Added a guard to reshape 1D predicted_values to (n, 1) before packaging, consistent with the expected 2D layout.

Test plan

  • Run the tuckute2024 benchmark end-to-end and confirm it scores without error
  • Confirm existing linear predictivity tests still pass

@KartikP KartikP added the OOM label Jun 6, 2026
@KartikP KartikP closed this Jun 6, 2026
@KartikP KartikP reopened this Jun 6, 2026

@KartikP KartikP left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bug fix looks good to me!

One thing I might recommend is adding a test.py to tuckute2024 as well as incrementing the benchmark version since incorrect scores through this bug exist.

@KartikP KartikP closed this Jun 6, 2026
@KartikP KartikP reopened this Jun 6, 2026
@KartikP KartikP closed this Jun 6, 2026
@KartikP KartikP reopened this Jun 6, 2026
@KartikP KartikP removed the OOM label Jun 6, 2026
@KartikP KartikP closed this Jun 6, 2026
@KartikP KartikP reopened this Jun 6, 2026

@KartikP KartikP left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@KartikP KartikP merged commit a897325 into brain-score:main Jun 6, 2026
44 of 53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants