Skip to content

Remove undici 7.18.2 override, bump wrangler to 4.83.0#49

Merged
bohdanbirdie merged 3 commits intomainfrom
chore/remove-undici-override
Apr 20, 2026
Merged

Remove undici 7.18.2 override, bump wrangler to 4.83.0#49
bohdanbirdie merged 3 commits intomainfrom
chore/remove-undici-override

Conversation

@bohdanbirdie
Copy link
Copy Markdown
Owner

@bohdanbirdie bohdanbirdie commented Apr 20, 2026

Summary

  • Bump wrangler 4.82.2 → 4.83.0 and @cloudflare/vite-plugin 1.32.2 → 1.32.3
  • Drop the overrides.undici: 7.18.2 workaround
  • Remove the tracking todo from docs/kanban

Why now

The override worked around a regression in undici 7.24.4 (shipped by miniflare) where isTraversableNavigable() incorrectly returned true, triggering browser-only 401 credential-retry logic against stream-backed bodies and crashing any POST with TypeError: fetch failed.

The fix has landed end-to-end:

  • Upstream undici: nodejs/undici#4941, backported to 7.x as #5006, released in undici 7.24.8.
  • Miniflare 4.20260415.0 bumps its pinned undici to 7.24.8 — see workers-sdk#13450 ("Fix POST/PUT requests with non-2xx responses throwing 'fetch failed'").
  • Wrangler 4.83.0 pulls that miniflare.

After this PR, undici resolves to 7.25.0 via miniflare's range.

Verified

  • bun run typecheck clean.
  • POST /api/ingest with bad/missing key now returns a 401 JSON body instead of crashing with TypeError: fetch failed.

Summary by CodeRabbit

Release Notes

  • Chores

    • Updated development dependencies for improved compatibility and stability.
    • Removed dependency version override, streamlining the project configuration.
  • Documentation

    • Reorganized development tasks and updated project status documentation.
    • Added notes on known blocking issues affecting test coverage on specific platforms, including details on the affected components and planned resolution steps.

miniflare 4.20260415.0 (via wrangler 4.83.0) pulls undici 7.24.8,
which includes the backported fix for the 401-with-request-body crash
(nodejs/undici#4941, cloudflare/workers-sdk#13450). The override is no
longer needed.
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 20, 2026

Warning

Rate limit exceeded

@bohdanbirdie has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 57 minutes and 56 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 57 minutes and 56 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e4d3ae37-8ccf-4e33-a7b0-0e3fdcacaa96

📥 Commits

Reviewing files that changed from the base of the PR and between a69c3f6 and 5b9ee37.

📒 Files selected for processing (2)
  • docs/diagrams/link-processor.excalidraw
  • docs/kanban.md
📝 Walkthrough

Walkthrough

Documentation and configuration updates addressing a Linux CI blocker for DO sync e2e testing, reorganizing kanban task statuses, removing outdated undici override documentation, and bumping Cloudflare devDependency versions while eliminating the associated undici override constraint.

Changes

Cohort / File(s) Summary
Documentation — Kanban Board
docs/kanban.md
Reformatted frontmatter, transitioned "Rethink app design" and "Fix links list rendering performance" from Todo to In Progress sections, and adjusted whitespace around kanban settings block.
Documentation — Issue Tracking
docs/todos/e2e-do-sync-testing.md, docs/todos/remove-undici-override.md
Added blocker documentation detailing Linux CI hang in miniflare-based DO sync e2e tests attributed to vitest-pool-workers WAL-mode SQLite sidecar handling, with upgrade path blocked on @effect/vitest stable support. Deleted obsolete undici override guidance.
Package Configuration
package.json
Bumped @cloudflare/vite-plugin (1.32.2 → 1.32.3) and wrangler (4.82.2 → 4.83.0); removed undici version override constraint.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

🐰 Hops through docs with glee,
Tasks march from Todo to In Progress spree,
Undici chains now shed away,
Cloudflare tools refreshed today,
A CI blocker caught and penned—
The kanban board shall now transcend!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately and specifically describes the main changes: removing the undici override and bumping wrangler version.
Description check ✅ Passed The description provides a comprehensive summary with clear context about what changed, why the change was needed (upstream fix), and verification steps, but lacks explicit alignment with the template sections (What, Why, Justification, Technical details).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/remove-undici-override

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented Apr 20, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
cloudstash 5b9ee37 Apr 20 2026, 10:45 AM

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
docs/kanban.md (1)

20-21: Nit: "Done" section contains an unchecked item.

Not part of this diff, but worth flagging while touching this file — Line 26 has - [ ] [[todos/publish-raycast-extension|...]] under the Done heading. Either move it back to In Progress/Todo or mark it [x] to keep the board consistent.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@docs/kanban.md` around lines 20 - 21, Under the "Done" section there's an
unchecked item `- [ ] [[todos/publish-raycast-extension|...]]`; either move that
checklist line back to the TODO/In Progress section or mark it completed by
changing the checkbox to `[x]` so the board's "Done" heading contains only
completed items; update the `- [ ] [[todos/publish-raycast-extension|...]]` line
accordingly and keep the rest of the Done section unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@docs/kanban.md`:
- Around line 20-21: Under the "Done" section there's an unchecked item `- [ ]
[[todos/publish-raycast-extension|...]]`; either move that checklist line back
to the TODO/In Progress section or mark it completed by changing the checkbox to
`[x]` so the board's "Done" heading contains only completed items; update the `-
[ ] [[todos/publish-raycast-extension|...]]` line accordingly and keep the rest
of the Done section unchanged.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 28d43265-7f80-46b6-abe3-f77699189536

📥 Commits

Reviewing files that changed from the base of the PR and between 5fa4a50 and a69c3f6.

⛔ Files ignored due to path filters (1)
  • bun.lock is excluded by !**/*.lock
📒 Files selected for processing (4)
  • docs/kanban.md
  • docs/todos/e2e-do-sync-testing.md
  • docs/todos/remove-undici-override.md
  • package.json
💤 Files with no reviewable changes (1)
  • docs/todos/remove-undici-override.md

- oxfmt pass on docs/kanban.md
- Sync link-processor excalidraw diagram
@bohdanbirdie bohdanbirdie merged commit 9070eb5 into main Apr 20, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant