Skip to content

Make nexpi PV optional so that it can be used on eiger's without extg#1152

Merged
RJCD-Diamond merged 5 commits into
mainfrom
nexpi
Dec 10, 2025
Merged

Make nexpi PV optional so that it can be used on eiger's without extg#1152
RJCD-Diamond merged 5 commits into
mainfrom
nexpi

Conversation

@RJCD-Diamond
Copy link
Copy Markdown
Contributor

@RJCD-Diamond RJCD-Diamond commented Dec 1, 2025

Fixes: #1117

Required to move ADOdin Eiger into dls-dodal

@RJCD-Diamond RJCD-Diamond requested a review from coretl December 1, 2025 10:41
@coretl
Copy link
Copy Markdown
Collaborator

coretl commented Dec 1, 2025

Shouldn't this happen in DiamondLightSource/dodal#1745 instead?

@RJCD-Diamond
Copy link
Copy Markdown
Contributor Author

RJCD-Diamond commented Dec 1, 2025

@coretl The nexpi pv is in the fastcs part of the eiger, unless you want me to move the fastcs odin to dodal as well?

The other option is making it optional, as I see you have agreed in the #1117 but I'm not aware of how to do this neatly

@coretl
Copy link
Copy Markdown
Collaborator

coretl commented Dec 2, 2025

@coretl The nexpi pv is in the fastcs part of the eiger, unless you want me to move the fastcs odin to dodal as well?

Ah, I get it now. I agree the change needs to be made here.

The other option is making it optional, as I see you have agreed in the #1117 but I'm not aware of how to do this neatly

You should just be able to replace the line with:

    nexpi: Optional[SignalRW[int]]

and the signal will not be created if it doesn't exist. If this doesn't work then we will fix that bit.

@RJCD-Diamond RJCD-Diamond changed the title remove nexpi Make nexpi PV optional so that it can be used on eiger's without extg Dec 9, 2025
@RJCD-Diamond
Copy link
Copy Markdown
Contributor Author

RJCD-Diamond commented Dec 10, 2025

nexpi: Optional[SignalRW[int]] was failing lint - so changed it to nexpi: SignalRW[int] | None

@RJCD-Diamond RJCD-Diamond merged commit ea5016b into main Dec 10, 2025
40 of 41 checks passed
@RJCD-Diamond RJCD-Diamond deleted the nexpi branch December 10, 2025 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

EigerDetectorIO nexpi PV should be optional or possibly removed?

2 participants