Skip to content

Wake agents from verified workflow mentions #6965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
loganj wants to merge 5 commits into
base: larry/workflow-revision-foundation-v4
Choose a base branch
from
Draft

Wake agents from verified workflow mentions #6965

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
67d4a4f
Wake agents from verified workflow mentions
loganj Aug 27, 2026
62018ae
Dispatch workflow mentions only after verification
loganj Aug 27, 2026
d0ee1b3
Enforce current access for workflow wakes
loganj Aug 27, 2026
ff5d36b
Allow safe kindless channel search
loganj Aug 27, 2026
c731d31
Recover workflow wakes across reconnects
Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions crates/buzz-acp/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ reqwest = { workspace = true }
# Serialization
serde = { workspace = true }
serde_json = { workspace = true }
serde_yaml = { workspace = true }

# IDs
uuid = { workspace = true }
Expand Down
36 changes: 32 additions & 4 deletions crates/buzz-acp/src/config.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1278,6 +1278,7 @@ pub fn resolve_channel_filters(
) -> HashMap<Uuid, ChannelFilter> {
use buzz_core::kind::{
KIND_STREAM_MESSAGE, KIND_STREAM_REMINDER, KIND_WORKFLOW_APPROVAL_REQUESTED,
KIND_WORKFLOW_MENTION_WAKE,
};

let target_channels: Vec<Uuid> = if let Some(ref overrides) = config.channels_override {
Expand All @@ -1297,6 +1298,7 @@ pub fn resolve_channel_filters(
let kinds = config.kinds_override.clone().unwrap_or_else(|| {
vec![
KIND_STREAM_MESSAGE,
KIND_WORKFLOW_MENTION_WAKE,
KIND_WORKFLOW_APPROVAL_REQUESTED,
KIND_STREAM_REMINDER,
]
Expand Down Expand Up @@ -1380,6 +1382,7 @@ pub fn resolve_dynamic_channel_filter(
) -> Option<ChannelFilter> {
use buzz_core::kind::{
KIND_STREAM_MESSAGE, KIND_STREAM_REMINDER, KIND_WORKFLOW_APPROVAL_REQUESTED,
KIND_WORKFLOW_MENTION_WAKE,
};

// In Mentions/All mode, if the operator explicitly constrained channels
Expand All @@ -1402,6 +1405,7 @@ pub fn resolve_dynamic_channel_filter(
kinds: Some(config.kinds_override.clone().unwrap_or_else(|| {
vec![
KIND_STREAM_MESSAGE,
KIND_WORKFLOW_MENTION_WAKE,
KIND_WORKFLOW_APPROVAL_REQUESTED,
KIND_STREAM_REMINDER,
]
Expand Down Expand Up @@ -1549,13 +1553,37 @@ mod tests {
for ch in &channels {
let f = result.get(ch).expect("channel should be present");
assert!(f.require_mention, "mentions mode requires mention");
let kinds = f.kinds.as_ref().expect("should have kinds");
assert!(kinds.contains(&buzz_core::kind::KIND_STREAM_MESSAGE));
assert!(kinds.contains(&buzz_core::kind::KIND_WORKFLOW_APPROVAL_REQUESTED));
assert!(kinds.contains(&buzz_core::kind::KIND_STREAM_REMINDER));
assert_eq!(
f.kinds,
Some(vec![
buzz_core::kind::KIND_STREAM_MESSAGE,
buzz_core::kind::KIND_WORKFLOW_MENTION_WAKE,
buzz_core::kind::KIND_WORKFLOW_APPROVAL_REQUESTED,
buzz_core::kind::KIND_STREAM_REMINDER,
])
);
}
}

#[test]
fn test_mentions_mode_dynamic_default_kinds_include_workflow_wake() {
let config = test_config(SubscribeMode::Mentions);
let channel = Uuid::new_v4();
let filter = resolve_dynamic_channel_filter(&config, channel, &[])
.expect("dynamic channel should be subscribed");

assert!(filter.require_mention);
assert_eq!(
filter.kinds,
Some(vec![
buzz_core::kind::KIND_STREAM_MESSAGE,
buzz_core::kind::KIND_WORKFLOW_MENTION_WAKE,
buzz_core::kind::KIND_WORKFLOW_APPROVAL_REQUESTED,
buzz_core::kind::KIND_STREAM_REMINDER,
])
);
}

#[test]
fn test_mentions_mode_custom_kinds() {
let mut config = test_config(SubscribeMode::Mentions);
Expand Down
60 changes: 59 additions & 1 deletion crates/buzz-acp/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ mod queue;
mod relay;
mod setup_mode;
mod usage;
mod workflow_wake;

pub use usage::TurnUsage;

Expand Down Expand Up @@ -2017,6 +2018,12 @@ async fn tokio_main() -> Result<()> {
tracing::warn!("failed to set startup watermark: {e}");
}

let workflow_relay_pubkey = relay
.rest_client()
.relay_signing_pubkey()
.await
.map_err(|e| anyhow::anyhow!("relay signing identity error: {e}"))?;

tracing::info!("connected to relay at {}", config.relay_url);

relay
Expand Down Expand Up @@ -2108,6 +2115,7 @@ async fn tokio_main() -> Result<()> {
kinds: config.kinds_override.clone().unwrap_or_else(|| {
vec![
KIND_STREAM_MESSAGE,
buzz_core::kind::KIND_WORKFLOW_MENTION_WAKE,
KIND_WORKFLOW_APPROVAL_REQUESTED,
KIND_STREAM_REMINDER,
]
Expand Down Expand Up @@ -2631,6 +2639,55 @@ async fn tokio_main() -> Result<()> {
match buzz_event {
Some(buzz_event) => {
let kind_u32 = buzz_event.event.kind.as_u16() as u32;
if workflow_wake::requires_verified_wake(
&buzz_event.event,
workflow_relay_pubkey,
) {
continue;
}

let (buzz_event, admission_author_override) = if kind_u32
== buzz_core::kind::KIND_WORKFLOW_MENTION_WAKE
{
let Some(wake) = buzz_core::workflow_wake::WorkflowMentionWake::parse(
&buzz_event.event,
)
.ok()
else {
continue;
};
let authority = match ctx
.rest_client
.workflow_wake_authority(wake.run_id(), &wake.message_event_id())
.await
{
Ok(authority) => authority,
Err(error) => {
tracing::warn!(%error, "workflow wake authority unavailable");
continue;
}
};
let Some((message, signed_author)) = workflow_wake::verify(
&buzz_event.event,
authority,
workflow_relay_pubkey,
config.keys.public_key(),
buzz_event.channel_id,
) else {
tracing::warn!("workflow wake authority verification failed");
continue;
};
(
relay::BuzzEvent {
channel_id: buzz_event.channel_id,
event: message,
},
Some(signed_author),
)
} else {
(buzz_event, None)
};
let kind_u32 = buzz_event.event.kind.as_u16() as u32;

if kind_u32 == KIND_MEMBER_ADDED_NOTIFICATION
|| kind_u32 == KIND_MEMBER_REMOVED_NOTIFICATION
Expand Down Expand Up @@ -2868,7 +2925,8 @@ async fn tokio_main() -> Result<()> {
// explicit pubkey list on top, for external people;
// it never revokes same-owner team bots.
{
let author = buzz_event.event.pubkey.to_hex();
let author = admission_author_override
.unwrap_or_else(|| buzz_event.event.pubkey.to_hex());
// DM hardening: resolve channel type (fail-closed
// to DM) so allowlist/anyone modes cannot be
// exercised by non-owner authors inside DMs.
Expand Down
Loading
Loading