Skip to content

Discover alternate Buzz ACP commands - #6948

Draft
loganj wants to merge 9 commits into
mainfrom
larry/discover-acp-wrappers
Draft

Discover alternate Buzz ACP commands#6948
loganj wants to merge 9 commits into
mainfrom
larry/discover-acp-wrappers

Conversation

@loganj

@loganj loganj commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

🤖 I’m Larry.

Summary

  • Discover installed executable commands named buzz-*-acp and offer them in the managed-agent editor.
  • Keep stock buzz-acp as the default and preserve arbitrary existing or newly entered custom commands.
  • Use the same command resolver for discovery and agent startup so the picker cannot advertise one executable while launching another.

Details

The ACP command field is now a dropdown with the stock harness, discovered wrapper aliases, and a Custom command option. Custom values remain editable while discovery is loading, unavailable, or changes later.

Discovery is read-only and never executes candidates. It filters non-files and non-executables, supports Windows .exe, .cmd, and .bat shims, deduplicates aliases, and returns stable sorted results. Command aliases remain dynamically resolved rather than persisting machine-specific absolute paths.

@github-actions

github-actions Bot commented Aug 27, 2026

Copy link
Copy Markdown

🔐 Codex Security Review

Status: review required for the current range.

The current range is 350caf1de3136f6ec473a69d394544e99dfd4d85...08f66ff4d1ef12f25f6f41abf3417317443be447.
A new review must complete for this exact range. When manual authorization
is required, a Block organization member must comment exactly
@buzz-security-review 08f66ff4d1ef12f25f6f41abf3417317443be447 to authorize a new review.
Any previous review applies only to its recorded range.

@loganj
loganj force-pushed the larry/discover-acp-wrappers branch from 68b9c71 to d857374 Compare August 27, 2026 20:53
@loganj
loganj marked this pull request as ready for review August 27, 2026 21:18
@loganj
loganj requested a review from a team as a code owner August 27, 2026 21:18
loganj and others added 6 commits August 27, 2026 20:22
Co-authored-by: Larry <8cf5a83f590ec0955b11647d1c88f796a98e088c30a492c58e0e46c3026ae7a4@nostr>
Signed-off-by: Logan Johnson <loganj@squareup.com>
Signed-off-by: Larry <8cf5a83f590ec0955b11647d1c88f796a98e088c30a492c58e0e46c3026ae7a4@buzz.block.builderlab.xyz>
Signed-off-by: Logan Johnson <loganj@squareup.com>
Co-authored-by: Larry <8cf5a83f590ec0955b11647d1c88f796a98e088c30a492c58e0e46c3026ae7a4@buzz.block.builderlab.xyz>
Signed-off-by: Logan Johnson <loganj@squareup.com>
Co-authored-by: Larry <8cf5a83f590ec0955b11647d1c88f796a98e088c30a492c58e0e46c3026ae7a4@buzz.block.builderlab.xyz>
Signed-off-by: Logan Johnson <loganj@squareup.com>

Co-authored-by: Larry <8cf5a83f590ec0955b11647d1c88f796a98e088c30a492c58e0e46c3026ae7a4@buzz.block.builderlab.xyz>
Signed-off-by: Logan Johnson <loganj@squareup.com>

Co-authored-by: Larry <8cf5a83f590ec0955b11647d1c88f796a98e088c30a492c58e0e46c3026ae7a4@buzz.block.builderlab.xyz>
Co-authored-by: Larry <8cf5a83f590ec0955b11647d1c88f796a98e088c30a492c58e0e46c3026ae7a4@buzz.block.builderlab.xyz>
Signed-off-by: Logan Johnson <loganj@squareup.com>
@loganj
loganj force-pushed the larry/discover-acp-wrappers branch from d857374 to a6ee9e1 Compare August 28, 2026 00:27
@loganj

loganj commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator Author

🤖 I’m Larry. Final user-visible proof after the profile-edit follow-up:

Discovered wrapper is selectable

Opening Edit on the deployed Tyler Agent exposes buzz-janet-acp under Advanced → ACP command.

ACP command picker showing buzz-janet-acp

Selection persists

After saving and reopening the same deployed profile, buzz-janet-acp remains selected.

Reopened Tyler Agent profile after saving

Validated on macOS Blox workstation buzz-pr6948-profile-proof-0005 (ID 2147524) at exact rebased head a6ee9e185ae477fca8bb6d4f6ddd1cb7427be80c:

  • just desktop-check — passed (existing informational Biome diagnostics only)
  • just desktop-typecheck — passed
  • just desktop-test — 5,723/5,723 passed
  • Focused Playwright product flow — 2/2 passed: wrapper discovery/selection/persistence and persona-linked profile Edit
  • Clean working tree confirmed

@loganj

loganj commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator Author

🤖 Larry: Added the missing read-only Agents-nav profile proof. Starting from Agents, opening Tyler Agent, and selecting Runtime shows Agent configuration → ACP command: buzz-janet-acp after save. The focused Playwright flow passed at PR head a6ee9e185ae477fca8bb6d4f6ddd1cb7427be80c.

Agents-nav profile showing persisted buzz-janet-acp

@loganj
loganj marked this pull request as draft August 28, 2026 00:56
Move ACP transport selection to the persona definition so create and edit flows preserve it through relay events, snapshots, and deployment. Keep legacy and unavailable commands compatible.

Co-authored-by: Larry <8cf5a83f590ec0955b11647d1c88f796a98e088c30a492c58e0e46c3026ae7a4@buzz.block.builderlab.xyz>
Signed-off-by: Larry <8cf5a83f590ec0955b11647d1c88f796a98e088c30a492c58e0e46c3026ae7a4@buzz.block.builderlab.xyz>
@loganj

loganj commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator Author

🤖 I’m Larry. I moved ACP transport ownership to the persona definition before deployment and pushed cc97c50c7cacc76a58b06baea1fce9a56f6fa8e8 to the draft PR.

  • Create/edit now selects a discovered ACP command beside the harness.
  • Persona relay events, local persistence, snapshots, and spawn inheritance preserve it.
  • Legacy personas retain buzz-acp; unknown persisted commands remain visible but unavailable.
  • Added round-trip, definition-to-instance, snapshot, and compatibility tests.

Validated at the exact head on Blox workstation larry-buzz-6948-fix (ID 2148985): Desktop check/typecheck/test passed (5,723 tests), root unit matrix passed with RUST_TEST_THREADS=1, and Tauri workspace tests passed. The parallel root matrix repeatedly exposed the same unrelated 40 ms buzz-agent timing flake; its focused test passed, and serialization made the full matrix pass.

The local push skipped tree-only test hooks because that exact SHA had the Blox validation above; branch-skew and file-size guards both passed locally.

PR remains draft: #6948

loganj and others added 2 commits August 27, 2026 21:58
Co-authored-by: Larry <8cf5a83f590ec0955b11647d1c88f796a98e088c30a492c58e0e46c3026ae7a4@buzz.block.builderlab.xyz>
Signed-off-by: Larry <8cf5a83f590ec0955b11647d1c88f796a98e088c30a492c58e0e46c3026ae7a4@buzz.block.builderlab.xyz>
Co-authored-by: Larry <8cf5a83f590ec0955b11647d1c88f796a98e088c30a492c58e0e46c3026ae7a4@buzz.block.builderlab.xyz>
Signed-off-by: Larry <8cf5a83f590ec0955b11647d1c88f796a98e088c30a492c58e0e46c3026ae7a4@buzz.block.builderlab.xyz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant