revert(desktop): restore explicit agent mentions - #6920
Draft
tellaho wants to merge 2 commits into
Draft
Conversation
Remove the composer auto-mention and persistent addressing stack while preserving unrelated draft and GIF work that landed afterward. Co-authored-by: Carl <acda9e433d19dcd0e6b6840f7f4b98f3a56f1fab98049d444c087019e6d36560@buzz.block.builderlab.xyz> Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
Update the restored persistence smoke tests to use the fresh storage keys so they exercise the rollback without reviving legacy state. Co-authored-by: Carl <acda9e433d19dcd0e6b6840f7f4b98f3a56f1fab98049d444c087019e6d36560@buzz.block.builderlab.xyz> Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
tellaho
force-pushed
the
tho/revert-composer-auto-mention
branch
from
August 27, 2026 14:44
f1efe78 to
daeb409
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category: fix
User Impact: Message composition returns to explicit mentions without automatic recipient insertion or per-message persistent addressing controls.
Problem: The newer composer behavior could silently carry addressed agents across sends and altered how mentions were inserted, making recipients harder to predict. Restoring the previous flow must also avoid reviving stale recipient state left in local storage.
Solution: Revert the composer auto-mention and addressing stack while preserving independent fixes that landed afterward, and version the restored persistence keys so every user starts from a clean, disabled state.
File changes
desktop/src-tauri/src/events/message_tags.rsRestored the previous explicit-mention behavior while retaining unrelated later fixes.
desktop/src/features/channels/ui/ChannelPane.tsxRestored the previous explicit-mention behavior while retaining unrelated later fixes.
desktop/src/features/channels/ui/useChannelPaneMessages.tsRestored the previous explicit-mention behavior while retaining unrelated later fixes.
desktop/src/features/communities/useCommunityInit.tsRestored the previous explicit-mention behavior while retaining unrelated later fixes.
desktop/src/features/forum/ui/ForumComposer.tsxRestored the previous explicit-mention behavior while retaining unrelated later fixes.
desktop/src/features/forum/ui/ForumComposerAutocompletes.tsxRestored the previous explicit-mention behavior while retaining unrelated later fixes.
desktop/src/features/home/ui/InboxDetailPane.tsxRestored the previous explicit-mention behavior while retaining unrelated later fixes.
desktop/src/features/messages/lib/agentAddressMention.d.mtsRemoved as part of the composer auto-mention and per-message addressing rollback.
desktop/src/features/messages/lib/agentAddressMention.mjsRemoved as part of the composer auto-mention and per-message addressing rollback.
desktop/src/features/messages/lib/agentAddressMention.test.mjsRemoved as part of the composer auto-mention and per-message addressing rollback.
desktop/src/features/messages/lib/applyEditTagOverlay.mjsRestored the previous explicit-mention behavior while retaining unrelated later fixes.
desktop/src/features/messages/lib/applyEditTagOverlay.test.mjsRestored the previous explicit-mention behavior while retaining unrelated later fixes.
desktop/src/features/messages/lib/autoPinMentionedAgentsPreference.test.mjsRemoved as part of the composer auto-mention and per-message addressing rollback.
desktop/src/features/messages/lib/autoPinMentionedAgentsPreference.tsRemoved as part of the composer auto-mention and per-message addressing rollback.
desktop/src/features/messages/lib/extractMentionPersonas.tsRemoved as part of the composer auto-mention and per-message addressing rollback.
desktop/src/features/messages/lib/getVisibleAgentAddressPubkeys.test.mjsRemoved as part of the composer auto-mention and per-message addressing rollback.
desktop/src/features/messages/lib/getVisibleAgentAddressPubkeys.tsRemoved as part of the composer auto-mention and per-message addressing rollback.
desktop/src/features/messages/lib/mentionCandidates.tsRestored the previous explicit-mention behavior while retaining unrelated later fixes.
desktop/src/features/messages/lib/mentionHighlightExtension.tsRestored the previous explicit-mention behavior while retaining unrelated later fixes.
desktop/src/features/messages/lib/mentionRanking.test.mjsRestored the previous explicit-mention behavior while retaining unrelated later fixes.
desktop/src/features/messages/lib/mentionRanking.tsRestored the previous explicit-mention behavior while retaining unrelated later fixes.
desktop/src/features/messages/lib/mentionSuggestionMapping.tsRestored the previous explicit-mention behavior while retaining unrelated later fixes.
desktop/src/features/messages/lib/persistentAgentAudience.test.mjsRestored persistence coverage and verifies legacy storage starts disabled and empty under the new keys.
desktop/src/features/messages/lib/persistentAgentAudience.tsRestored thread-scoped persistent audiences with new storage-key versions so stale saved recipients and enablement do not reactivate.
desktop/src/features/messages/lib/recentMentionPubkeys.test.mjsRemoved as part of the composer auto-mention and per-message addressing rollback.
desktop/src/features/messages/lib/recentMentionPubkeys.tsRemoved as part of the composer auto-mention and per-message addressing rollback.
desktop/src/features/messages/lib/useActiveAgentPubkeys.tsRemoved as part of the composer auto-mention and per-message addressing rollback.
desktop/src/features/messages/lib/useDefaultAgentSuggestion.tsRemoved as part of the composer auto-mention and per-message addressing rollback.
desktop/src/features/messages/lib/useMentionSelection.tsRemoved as part of the composer auto-mention and per-message addressing rollback.
desktop/src/features/messages/lib/useMentions.tsRestored the previous explicit-mention behavior while retaining unrelated later fixes.
desktop/src/features/messages/lib/useRichTextEditor.tsRestored the previous explicit-mention behavior while retaining unrelated later fixes.
desktop/src/features/messages/ui/ComposerAddressControls.test.mjsRemoved as part of the composer auto-mention and per-message addressing rollback.
desktop/src/features/messages/ui/ComposerAddressControls.tsxRemoved as part of the composer auto-mention and per-message addressing rollback.
desktop/src/features/messages/ui/MentionAutocomplete.test.mjsRestored the previous explicit-mention behavior while retaining unrelated later fixes.
desktop/src/features/messages/ui/MentionAutocomplete.tsxRestored the previous explicit-mention behavior while retaining unrelated later fixes.
desktop/src/features/messages/ui/MessageAgentAddressPrefix.tsxRemoved as part of the composer auto-mention and per-message addressing rollback.
desktop/src/features/messages/ui/MessageComposer.tsxRestored the previous explicit-mention behavior while retaining unrelated later fixes. Blank-line-only compaction keeps the restored source under the repository file-size ratchet.
desktop/src/features/messages/ui/MessageComposer.types.tsRestored the previous explicit-mention behavior while retaining unrelated later fixes.
desktop/src/features/messages/ui/MessageComposerToolbar.tsxRestored the previous explicit-mention behavior while retaining unrelated later fixes.
desktop/src/features/messages/ui/MessageRow.tsxRestored the previous explicit-mention behavior while retaining unrelated later fixes.
desktop/src/features/messages/ui/MessageThreadPanel.tsxRestored the previous explicit-mention behavior while retaining unrelated later fixes.
desktop/src/features/messages/ui/composerAgentKeyboard.test.mjsRemoved as part of the composer auto-mention and per-message addressing rollback.
desktop/src/features/messages/ui/persistentAgentAudienceHosts.test.mjsRestored the previous explicit-mention behavior while retaining unrelated later fixes.
desktop/src/features/messages/ui/useAddressMentionPulse.test.mjsRemoved as part of the composer auto-mention and per-message addressing rollback.
desktop/src/features/messages/ui/useAddressMentionPulse.tsRemoved as part of the composer auto-mention and per-message addressing rollback.
desktop/src/features/messages/ui/useAgentAddressLockPicker.test.mjsRemoved as part of the composer auto-mention and per-message addressing rollback.
desktop/src/features/messages/ui/useAgentAddressLockPicker.tsRemoved as part of the composer auto-mention and per-message addressing rollback.
desktop/src/features/messages/ui/useAlwaysAddressShortcut.tsRemoved as part of the composer auto-mention and per-message addressing rollback.
desktop/src/features/messages/ui/useAutoPinMentionedAgents.tsRemoved as part of the composer auto-mention and per-message addressing rollback.
desktop/src/features/messages/ui/useComposerMentionPicker.tsRemoved as part of the composer auto-mention and per-message addressing rollback.
desktop/src/features/messages/ui/useComposerPasteHandler.tsRemoved as part of the composer auto-mention and per-message addressing rollback.
desktop/src/features/messages/ui/useMentionSendFlow.helpers.test.mjsRemoved as part of the composer auto-mention and per-message addressing rollback.
desktop/src/features/messages/ui/useMentionSendFlow.helpers.tsRestored the previous explicit-mention behavior while retaining unrelated later fixes.
desktop/src/features/messages/ui/useMentionSendFlow.tsRestored the previous explicit-mention behavior while retaining unrelated later fixes. Blank-line-only compaction keeps the restored source under the repository file-size ratchet.
desktop/src/features/messages/ui/useMentionSendFlow.types.tsRemoved as part of the composer auto-mention and per-message addressing rollback.
desktop/src/features/messages/ui/usePersistentAgentMentionHydration.tsRestored the previous composer behavior needed after the addressing rollback.
desktop/src/features/settings/ui/AgentsSettingsPanel.tsxRestored the previous explicit-mention behavior while retaining unrelated later fixes.
desktop/src/features/settings/ui/PreventSleepSettingsCard.tsxRestored the previous explicit-mention behavior while retaining unrelated later fixes.
desktop/src/shared/lib/keyboard-shortcuts.tsRestored the previous explicit-mention behavior while retaining unrelated later fixes.
desktop/src/shared/ui/VideoReviewCommentMarkdown.tsxRestored the previous explicit-mention behavior while retaining unrelated later fixes.
desktop/tests/e2e/mentions.spec.tsRestored the previous explicit-mention behavior while retaining unrelated later fixes.
desktop/tests/e2e/persistent-agent-audience.spec.tsRestored the previous explicit-mention behavior while retaining unrelated later fixes.
desktop/tests/e2e/profile.spec.tsRestored the previous explicit-mention behavior while retaining unrelated later fixes.
desktop/tests/e2e/send-channel-binding.spec.tsRestored the previous explicit-mention behavior while retaining unrelated later fixes.
Reproduction steps
buzz:keep-addressed-agents-activeandbuzz:persistent-agent-audiences:v2keys, reload, and verify persistent addressing starts disabled with no restored recipients.