Skip to content

1360 error failed to parse model #1469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pablo-mayrgundter wants to merge 2 commits into
base: main
Choose a base branch
from
Open

1360 error failed to parse model #1469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ca727c
Add test for GitHub URL parsing guard
pablo-mayrgundter Feb 4, 2026
d6175fc
Merge pull request #1468 from bldrs-ai/codex/investigate-and-fix-ifc-…
pablo-mayrgundter Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/net/github/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,13 @@ export const parseGitHubRepositoryUrl = (githubUrl) => {
if (host !== 'github.com' && host !== 'raw.githubusercontent.com') {
throw new Error('Not a valid GitHub repository URL')
}
const match = url.pathname.match(`^/${pathParts.join('/')}$`)
if (match === null) {
const match = re.exec(url.pathname)
if (!match) {
throw new Error('Could not match GitHub repository URL')
}
if (!match.groups) {
throw new Error('GitHub repository URL does not expose named groups')
}
const {groups: {org, repo, branch, file}} = match
return {
url: url,
Expand Down
8 changes: 8 additions & 0 deletions src/net/github/utils.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,14 @@ describe('net/github/utils', () => {
expect(actual.ref).toEqual('main')
expect(actual.path).toEqual('haus.ifc')
})

it('throws an error if a match has no named capture groups', () => {
const execSpy = jest.spyOn(RegExp.prototype, 'exec')
execSpy.mockReturnValueOnce([''])
expect(() => parseGitHubRepositoryUrl('https://github.com/org/repo/blob/main/file.ifc'))
.toThrowError('GitHub repository URL does not expose named groups')
execSpy.mockRestore()
})
})


Expand Down
Loading