refactor: use only camelCase - #16
Open
simenandre wants to merge 5 commits into
Open
Conversation
braaar
approved these changes
Jul 4, 2023
braaar
left a comment
braaar
left a comment
Member
There was a problem hiding this comment.
Nice! I agree with this change
Member
I think we should remove these types and the |
simenandre
force-pushed
the
simenandre/use-camel-case
branch
from
July 22, 2023 12:09
b3f7651 to
c8a756b
Compare
simenandre
force-pushed
the
simenandre/use-camel-case
branch
from
July 22, 2023 12:37
be1ee20 to
e5a95e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This starts work on migrating to using only camelCase, which is obviously a breaking change.
I'm using transform function to do this:
colinhacks/zod#486 (comment)
I added
common.ts, which holds a few common functions such asmakeSearchParams. This might remove the need for bothmakeQueryandmakeBody.Also, @braaar, I don't understand the
QueryEnvelopeandBodyEnvelope, I moved the list trips method away from that. There might be something I'm missing?