Skip to content

[PM-33417] WebAuthn cache#7500

Merged
ike-kottlowski merged 17 commits intomainfrom
auth/pm-33417/webauthn-cache
Apr 30, 2026
Merged

[PM-33417] WebAuthn cache#7500
ike-kottlowski merged 17 commits intomainfrom
auth/pm-33417/webauthn-cache

Conversation

@ike-kottlowski
Copy link
Copy Markdown
Contributor

@ike-kottlowski ike-kottlowski commented Apr 17, 2026

🎟️ Tracking

PM-33417

📔 Objective

@ike-kottlowski ike-kottlowski requested a review from a team as a code owner April 17, 2026 22:15
@ike-kottlowski ike-kottlowski requested a review from rr-bw April 17, 2026 22:15
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 17, 2026

Logo
Checkmarx One – Scan Summary & Details2c201350-2d6a-4ed3-a6c0-aba547c7058f


New Issues (9) Checkmarx found the following issues in this Pull Request
# Severity Issue Source File / Package Checkmarx Insight
1 MEDIUM CSRF src/Api/AdminConsole/Controllers/GroupsController.cs: 275
detailsMethod at line 275 of /src/Api/AdminConsole/Controllers/GroupsController.cs gets a parameter from a user request from orgUserId. This parameter ...
Attack Vector
2 MEDIUM CSRF src/Api/Vault/Controllers/CiphersController.cs: 1558
detailsMethod at line 1558 of /src/Api/Vault/Controllers/CiphersController.cs gets a parameter from a user request from id. This parameter value flows ...
Attack Vector
3 MEDIUM CSRF src/Api/Vault/Controllers/CiphersController.cs: 1385
detailsMethod at line 1385 of /src/Api/Vault/Controllers/CiphersController.cs gets a parameter from a user request from id. This parameter value flows ...
Attack Vector
4 MEDIUM CSRF src/Api/AdminConsole/Controllers/GroupsController.cs: 127
detailsMethod at line 127 of /src/Api/AdminConsole/Controllers/GroupsController.cs gets a parameter from a user request from model. This parameter valu...
Attack Vector
5 MEDIUM CSRF src/Api/AdminConsole/Controllers/GroupsController.cs: 151
detailsMethod at line 151 of /src/Api/AdminConsole/Controllers/GroupsController.cs gets a parameter from a user request from model. This parameter valu...
Attack Vector
6 MEDIUM CSRF src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 393
detailsMethod at line 393 of /src/Api/AdminConsole/Controllers/OrganizationUsersController.cs gets a parameter from a user request from model. This par...
Attack Vector
7 MEDIUM CSRF src/Api/AdminConsole/Public/Controllers/GroupsController.cs: 164
detailsMethod at line 164 of /src/Api/AdminConsole/Public/Controllers/GroupsController.cs gets a parameter from a user request from model. This paramet...
Attack Vector
8 MEDIUM CSRF src/Api/AdminConsole/Public/Controllers/MembersController.cs: 232
detailsMethod at line 232 of /src/Api/AdminConsole/Public/Controllers/MembersController.cs gets a parameter from a user request from model. This parame...
Attack Vector
9 MEDIUM CSRF src/Api/AdminConsole/Public/Controllers/MembersController.cs: 269
detailsMethod at line 269 of /src/Api/AdminConsole/Public/Controllers/MembersController.cs gets a parameter from a user request from model. This parame...
Attack Vector

Fixed Issues (7) Great job! The following issues were fixed in this Pull Request
Severity Issue Source File / Package
MEDIUM CSRF src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 393
MEDIUM CSRF src/Api/AdminConsole/Controllers/GroupsController.cs: 151
MEDIUM CSRF src/Api/AdminConsole/Controllers/GroupsController.cs: 127
MEDIUM CSRF src/Api/AdminConsole/Public/Controllers/MembersController.cs: 232
MEDIUM CSRF src/Api/AdminConsole/Controllers/GroupsController.cs: 275
MEDIUM CSRF src/Api/AdminConsole/Public/Controllers/MembersController.cs: 269
MEDIUM CSRF src/Api/AdminConsole/Public/Controllers/GroupsController.cs: 167

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.49%. Comparing base (9c02f0c) to head (e08e34d).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7500      +/-   ##
==========================================
+ Coverage   59.26%   59.49%   +0.23%     
==========================================
  Files        2082     2089       +7     
  Lines       92060    92376     +316     
  Branches     8181     8207      +26     
==========================================
+ Hits        54556    54962     +406     
+ Misses      35563    35473      -90     
  Partials     1941     1941              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rr-bw rr-bw requested review from enmande and removed request for rr-bw April 17, 2026 23:20
enmande
enmande previously approved these changes Apr 21, 2026
Copy link
Copy Markdown
Contributor

@enmande enmande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question, below. Thank you!

@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

@enmande enmande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ thank you!

@ike-kottlowski ike-kottlowski merged commit 90f451b into main Apr 30, 2026
51 checks passed
@ike-kottlowski ike-kottlowski deleted the auth/pm-33417/webauthn-cache branch April 30, 2026 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants