[PM-33473] Remove pm-29594-update-individual-subscription-page feature flag#7496
Closed
amorask-bitwarden wants to merge 1 commit intomainfrom
Closed
[PM-33473] Remove pm-29594-update-individual-subscription-page feature flag#7496amorask-bitwarden wants to merge 1 commit intomainfrom
amorask-bitwarden wants to merge 1 commit intomainfrom
Conversation
|
Contributor
|
Great job! No new security vulnerabilities introduced in this pull request |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #7496 +/- ##
==========================================
- Coverage 59.10% 59.01% -0.10%
==========================================
Files 2078 2081 +3
Lines 91526 91428 -98
Branches 8141 8122 -19
==========================================
- Hits 54100 53952 -148
- Misses 35500 35554 +54
+ Partials 1926 1922 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-33473
📔 Objective
Remove the
pm-29594-update-individual-subscription-pagefeature flag and its flagged code paths per the Feature Flags Lifecycle process.Changes:
PM29594_UpdateIndividualSubscriptionPageconstant fromConstants.cs.[RequireFeature(FeatureFlagKeys.PM29594_UpdateIndividualSubscriptionPage)]attributes fromAccountBillingVNextControlleronGetSubscriptionAsync,ReinstateSubscriptionAsync, andUpdateSubscriptionStorageAsync— the vNext endpoints become unconditional for cloud.PostStorageAsyncandPostReinstateAsyncfromAccountsControlleralong with their tests.AdjustStorageAsyncandReinstatePremiumAsyncfromUserServiceandIUserServicealong with their tests.AccountsController.GetSubscriptionAsyncto a self-hosted-only endpoint ([SelfHosted(SelfHostedOnly = true)]) becauseSelfHostedAccountSubscriptionComponenton the clients side still needs it — the vNext replacement is cloud-only ([SelfHosted(NotSelfHostedOnly = true)]). The response modelSubscriptionResponseModelis simplified to only the fields self-hosted requires:StorageName,StorageGb,MaxStorageGb,Expiration.BillingCustomerDiscount,BillingSubscription,BillingSubscriptionUpcomingInvoice) from the formerSubscriptionResponseModel.csinto standalone files undersrc/Api/Models/Response/in the same namespace.OrganizationResponseModel.csstill consumes them viausing Bit.Api.Models.Response;and needs no changes.Paired with the companion clients PR that removes the flag + dead code on the client side.
📸 Screenshots
N/A — no UI changes.