Skip to content

[PM 34174]Do not show renewal reminder banners to exempt organizations#7483

Open
cyprain-okeke wants to merge 6 commits intomainfrom
billing/pm-34174/do-not-show-renewal-reminder-banners-to-exempt-organizations
Open

[PM 34174]Do not show renewal reminder banners to exempt organizations#7483
cyprain-okeke wants to merge 6 commits intomainfrom
billing/pm-34174/do-not-show-renewal-reminder-banners-to-exempt-organizations

Conversation

@cyprain-okeke
Copy link
Copy Markdown
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-34174

📔 Objective

Suppress billing renewal reminder banners and subscription status callouts for organizations that are exempt from billing
automation.

Reseller-managed organizations marked as exempt (exemptFromBillingAutomation = true) should not see renewal cycle notifications or
warning callouts related to past due, unpaid, pending cancellation, or canceled subscription statuses.

Changes

  • Added exemptFromBillingAutomation field to the organization model pipeline (ProfileOrganizationResponse → OrganizationData →
    Organization)
  • Gated getResellerRenewalWarning$() in OrganizationWarningsService to return null for exempt organizations, skipping the API call
    entirely
  • Added exempt input to SubscriptionStatusComponent to suppress warning callouts (past_due, unpaid, pending_cancellation, canceled)
    while preserving status and date display
  • Passed userOrg.exemptFromBillingAutomation to the SubscriptionStatusComponent from the cloud subscription template

Screenshots & Testing
Testing

  • Verified exempt organizations do not see reseller renewal banners
  • Verified exempt organizations do not see subscription status callouts
  • Verified non-exempt organizations continue to see all warnings as before
  • Unit tests added for both OrganizationWarningsService and SubscriptionStatusComponent

📸 Screenshots

Screenshot 2026-04-16 at 2 27 19 PM Screenshot 2026-04-16 at 2 26 57 PM Screenshot 2026-04-16 at 2 10 06 PM Screenshot 2026-04-16 at 2 09 41 PM Screenshot 2026-04-16 at 1 57 57 PM Screenshot 2026-04-16 at 1 57 08 PM Screenshot 2026-04-16 at 1 53 55 PM Screenshot 2026-04-16 at 1 46 14 PM

@cyprain-okeke cyprain-okeke requested review from a team as code owners April 16, 2026 14:24
@cyprain-okeke cyprain-okeke requested a review from JaredScar April 16, 2026 14:24
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 16, 2026

Logo
Checkmarx One – Scan Summary & Details1e9c3966-f606-4847-a10f-9162689760d6


New Issues (2) Checkmarx found the following issues in this Pull Request
# Severity Issue Source File / Package Checkmarx Insight
1 MEDIUM CSRF src/Api/Vault/Controllers/CiphersController.cs: 1558
detailsMethod at line 1558 of /src/Api/Vault/Controllers/CiphersController.cs gets a parameter from a user request from id. This parameter value flows ...
Attack Vector
2 MEDIUM CSRF src/Api/Vault/Controllers/CiphersController.cs: 1385
detailsMethod at line 1385 of /src/Api/Vault/Controllers/CiphersController.cs gets a parameter from a user request from id. This parameter value flows ...
Attack Vector

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.61%. Comparing base (2820ecc) to head (b329e2a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7483      +/-   ##
==========================================
+ Coverage   59.14%   63.61%   +4.47%     
==========================================
  Files        2077     2077              
  Lines       91859    91865       +6     
  Branches     8177     8177              
==========================================
+ Hits        54326    58440    +4114     
+ Misses      35601    31407    -4194     
- Partials     1932     2018      +86     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

mkincaid-bw
mkincaid-bw previously approved these changes Apr 16, 2026
JaredScar
JaredScar previously approved these changes Apr 16, 2026
@cyprain-okeke cyprain-okeke dismissed stale reviews from JaredScar and mkincaid-bw via b329e2a April 23, 2026 13:50
@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants