Skip to content

[PM-34909] Serve only validated report files from get-latest and self-hosted file endpoints #7465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
AlexRubik wants to merge 138 commits into
base: main
Choose a base branch
from

fix(dirt): fix test setup for upload guard and flag-OFF test

efa1321
Select commit
Loading
Failed to load commit list.
Draft

[PM-34909] Serve only validated report files from get-latest and self-hosted file endpoints #7465

fix(dirt): fix test setup for upload guard and flag-OFF test
efa1321
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 14, 2026 in 0s

63.22% (+4.72%) compared to f6e858b

View this Pull Request on Codecov

63.22% (+4.72%) compared to f6e858b

Details

Codecov Report

❌ Patch coverage is 77.94317% with 163 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.22%. Comparing base (f6e858b) to head (efa1321).
⚠️ Report is 44 commits behind head on main.

Files with missing lines Patch % Lines
.../Dirt/Controllers/OrganizationReportsController.cs 69.23% 64 Missing and 8 partials ⚠️
.../Services/AzureOrganizationReportStorageService.cs 36.14% 52 Missing and 1 partial ⚠️
.../Services/LocalOrganizationReportStorageService.cs 83.82% 10 Missing and 1 partial ⚠️
.../Dirt/Repositories/OrganizationReportRepository.cs 0.00% 8 Missing ⚠️
...SharedWeb/Utilities/ServiceCollectionExtensions.cs 27.27% 6 Missing and 2 partials ⚠️
...s/Services/NoopOrganizationReportStorageService.cs 0.00% 7 Missing ⚠️
...rts/ReportFeatures/AddOrganizationReportCommand.cs 0.00% 0 Missing and 1 partial ⚠️
.../ReportFeatures/CreateOrganizationReportCommand.cs 98.68% 0 Missing and 1 partial ⚠️
...ports/ReportFeatures/GetOrganizationReportQuery.cs 85.71% 1 Missing ⚠️
...ucture.Dapper/Dirt/OrganizationReportRepository.cs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7465      +/-   ##
==========================================
+ Coverage   58.49%   63.22%   +4.72%     
==========================================
  Files        2063     2076      +13     
  Lines       91190    91527     +337     
  Branches     8130     8129       -1     
==========================================
+ Hits        53342    57866    +4524     
+ Misses      35949    31658    -4291     
- Partials     1899     2003     +104

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov