Skip to content

[PM-23355] - use MP reprompt in bulk assign to collections#20249

Merged
jaasen-livefront merged 1 commit intomainfrom
PM-23355
Apr 24, 2026
Merged

[PM-23355] - use MP reprompt in bulk assign to collections#20249
jaasen-livefront merged 1 commit intomainfrom
PM-23355

Conversation

@jaasen-livefront
Copy link
Copy Markdown
Collaborator

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-23355

📔 Objective

This PR adds the repromptCipher check at the top of bulkAssignToCollections to align with the PM behavior.

📸 Screenshots

Screen.Recording.2026-04-17.at.3.57.34.PM.mov

@jaasen-livefront jaasen-livefront requested a review from a team as a code owner April 17, 2026 23:00
@jaasen-livefront jaasen-livefront changed the title use MP reprompt in bulk assign to collections [PM-23355] - use MP reprompt in bulk assign to collections Apr 17, 2026
@sonarqubecloud
Copy link
Copy Markdown

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 17, 2026

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.76%. Comparing base (3140be4) to head (50915b8).
⚠️ Report is 72 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...nsole/organizations/collections/vault.component.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20249      +/-   ##
==========================================
+ Coverage   46.67%   46.76%   +0.08%     
==========================================
  Files        3906     3906              
  Lines      117798   118062     +264     
  Branches    18038    18092      +54     
==========================================
+ Hits        54983    55207     +224     
- Misses      58667    58683      +16     
- Partials     4148     4172      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

Logo
Checkmarx One – Scan Summary & Details9faf56f7-5bec-4ca9-8e6b-782c59ed2055

Great job! No new security vulnerabilities introduced in this pull request

@jaasen-livefront jaasen-livefront merged commit ebcb714 into main Apr 24, 2026
66 checks passed
@jaasen-livefront jaasen-livefront deleted the PM-23355 branch April 24, 2026 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants