Skip to content

[PM-34832] Fix account recovery strings#20248

Open
kspearrin wants to merge 1 commit intomainfrom
recoverystrings
Open

[PM-34832] Fix account recovery strings#20248
kspearrin wants to merge 1 commit intomainfrom
recoverystrings

Conversation

@kspearrin
Copy link
Copy Markdown
Member

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-34832

📔 Objective

Fix 2FA recovery string, per spec.

@sonarqubecloud
Copy link
Copy Markdown

@kspearrin
Copy link
Copy Markdown
Member Author

kspearrin commented Apr 17, 2026

How should I handle the lint failure for the locale strings here? Some of this is changing strings for stuff we haven't even released yet, but its failing because I am modifying an existing string.

@github-actions
Copy link
Copy Markdown
Contributor

Logo
Checkmarx One – Scan Summary & Details05d6552f-221b-41f4-a229-54e77b87a678

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@086c625). Learn more about missing BASE report.
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #20248   +/-   ##
=======================================
  Coverage        ?   46.66%           
=======================================
  Files           ?     3906           
  Lines           ?   117766           
  Branches        ?    18031           
=======================================
  Hits            ?    54953           
  Misses          ?    58671           
  Partials        ?     4142           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kspearrin kspearrin requested a review from a team April 27, 2026 15:32
@BTreston BTreston self-requested a review April 27, 2026 15:42
Copy link
Copy Markdown
Contributor

@BTreston BTreston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't mutate existing copy strings (see CI error), these will need new keys. Also just a fyi: the reviewer team you'll want to tag in GH is team-admin-console-dev. That way its more visible to the team, TY 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants