Conversation
|
|
How should I handle the lint failure for the locale strings here? Some of this is changing strings for stuff we haven't even released yet, but its failing because I am modifying an existing string. |
|
Great job! No new security vulnerabilities introduced in this pull request |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #20248 +/- ##
=======================================
Coverage ? 46.66%
=======================================
Files ? 3906
Lines ? 117766
Branches ? 18031
=======================================
Hits ? 54953
Misses ? 58671
Partials ? 4142 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
BTreston
left a comment
There was a problem hiding this comment.
We can't mutate existing copy strings (see CI error), these will need new keys. Also just a fyi: the reviewer team you'll want to tag in GH is team-admin-console-dev. That way its more visible to the team, TY 👍




🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-34832
📔 Objective
Fix 2FA recovery string, per spec.