Skip to content

[BEEEP] Improve speed performance of Admin Console Collections page #20243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JaredScar wants to merge 10 commits into
base: main
Choose a base branch
from

refactor(vault): remove redundant cipher indexing call in search process

f659f8c
Select commit
Loading
Failed to load commit list.
Open

[BEEEP] Improve speed performance of Admin Console Collections page #20243

refactor(vault): remove redundant cipher indexing call in search process
f659f8c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 24, 2026 in 0s

46.97% (-0.04%) compared to f73e2be

View this Pull Request on Codecov

46.97% (-0.04%) compared to f73e2be

Details

Codecov Report

❌ Patch coverage is 6.42857% with 131 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.97%. Comparing base (f73e2be) to head (f659f8c).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
libs/common/src/vault/services/search.worker.ts 0.00% 61 Missing ⚠️
...nsole/organizations/collections/vault.component.ts 0.00% 42 Missing ⚠️
...tions/services/default-collection-admin.service.ts 0.00% 14 Missing ⚠️
libs/common/src/vault/services/cipher.service.ts 10.00% 9 Missing ⚠️
...lt/components/vault-items/vault-items.component.ts 62.50% 1 Missing and 2 partials ⚠️
...ault/services/default-cipher-encryption.service.ts 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #20243      +/-   ##
==========================================
- Coverage   47.01%   46.97%   -0.04%     
==========================================
  Files        3912     3913       +1     
  Lines      118440   118554     +114     
  Branches    18117    18130      +13     
==========================================
+ Hits        55681    55688       +7     
- Misses      58571    58674     +103     
- Partials     4188     4192       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov