[PM-33473] Remove pm-29594-update-individual-subscription-page feature flag#20240
Closed
amorask-bitwarden wants to merge 1 commit intomainfrom
Closed
[PM-33473] Remove pm-29594-update-individual-subscription-page feature flag#20240amorask-bitwarden wants to merge 1 commit intomainfrom
amorask-bitwarden wants to merge 1 commit intomainfrom
Conversation
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #20240 +/- ##
==========================================
+ Coverage 46.54% 46.63% +0.08%
==========================================
Files 3898 3901 +3
Lines 117583 117480 -103
Branches 18002 17974 -28
==========================================
+ Hits 54729 54781 +52
+ Misses 58733 58580 -153
+ Partials 4121 4119 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Great job! No new security vulnerabilities introduced in this pull request |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-33473
📔 Objective
Remove the
pm-29594-update-individual-subscription-pagefeature flag and its flagged code paths per the Feature Flags Lifecycle process.Changes:
PM29594_UpdateIndividualSubscriptionPageenum member and its defaults-map entry fromlibs/common/src/enums/feature-flag.enum.ts.postReinstatePremium(implementation and abstract) fromlibs/common/src/services/api.service.tsandlibs/common/src/abstractions/api.service.ts.subscription.component.ts—showSubscriptionPageLink$now always takes thebillingAccountProfileStateService.hasPremiumPersonally$(account.id)path; dropConfigService,AccountBillingClient,LogService,FeatureFlag, and thecombineLatest/catchErrorbranch.individual-billing-routing.module.ts— remove theisSubscriptionPageEnabledcanMatchguard and the fallback route pointing toUserSubscriptionComponent. The/user-subscriptiontree is now a clean two-route (self-hosted + cloud) pattern matching/premium.UserSubscriptionComponent(.tsand.html) and drop it from the module declarations.apiService.postAccountStorageelse-branch inAdjustStorageDialogComponent: tightenorganizationIdfrom optional to required (matches the sole remaining caller), remove theapiServicedependency, deletepostAccountStoragefrom the API service abstraction/implementation, and drop orphanedStorageRequestimports.Paired with the companion server PR that removes the corresponding endpoints and keeps
GET /accounts/subscriptionas self-hosted-only for theSelfHostedAccountSubscriptionComponent.📸 Screenshots
N/A — no UI changes (removing a feature-flagged component; the
/user-subscriptionroutes now always showCloudHostedAccountSubscriptionComponentfor cloud andSelfHostedAccountSubscriptionComponentfor self-hosted, which was the intended final state).