Skip to content

[PM-33473] Remove pm-29594-update-individual-subscription-page feature flag#20240

Closed
amorask-bitwarden wants to merge 1 commit intomainfrom
billing/PM-33473/remove-pm29594-feature-flag
Closed

[PM-33473] Remove pm-29594-update-individual-subscription-page feature flag#20240
amorask-bitwarden wants to merge 1 commit intomainfrom
billing/PM-33473/remove-pm29594-feature-flag

Conversation

@amorask-bitwarden
Copy link
Copy Markdown
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-33473

📔 Objective

Remove the pm-29594-update-individual-subscription-page feature flag and its flagged code paths per the Feature Flags Lifecycle process.

Changes:

  • Remove the PM29594_UpdateIndividualSubscriptionPage enum member and its defaults-map entry from libs/common/src/enums/feature-flag.enum.ts.
  • Delete postReinstatePremium (implementation and abstract) from libs/common/src/services/api.service.ts and libs/common/src/abstractions/api.service.ts.
  • Simplify subscription.component.tsshowSubscriptionPageLink$ now always takes the billingAccountProfileStateService.hasPremiumPersonally$(account.id) path; drop ConfigService, AccountBillingClient, LogService, FeatureFlag, and the combineLatest/catchError branch.
  • Update individual-billing-routing.module.ts — remove the isSubscriptionPageEnabled canMatch guard and the fallback route pointing to UserSubscriptionComponent. The /user-subscription tree is now a clean two-route (self-hosted + cloud) pattern matching /premium.
  • Delete UserSubscriptionComponent (.ts and .html) and drop it from the module declarations.
  • Clean up the now-dead apiService.postAccountStorage else-branch in AdjustStorageDialogComponent: tighten organizationId from optional to required (matches the sole remaining caller), remove the apiService dependency, delete postAccountStorage from the API service abstraction/implementation, and drop orphaned StorageRequest imports.

Paired with the companion server PR that removes the corresponding endpoints and keeps GET /accounts/subscription as self-hosted-only for the SelfHostedAccountSubscriptionComponent.

📸 Screenshots

N/A — no UI changes (removing a feature-flagged component; the /user-subscription routes now always show CloudHostedAccountSubscriptionComponent for cloud and SelfHostedAccountSubscriptionComponent for self-hosted, which was the intended final state).

@sonarqubecloud
Copy link
Copy Markdown

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 17, 2026

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.63%. Comparing base (dc94f96) to head (d0e2b64).
⚠️ Report is 48 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...c/app/billing/individual/subscription.component.ts 0.00% 3 Missing ⚠️
...-storage-dialog/adjust-storage-dialog.component.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20240      +/-   ##
==========================================
+ Coverage   46.54%   46.63%   +0.08%     
==========================================
  Files        3898     3901       +3     
  Lines      117583   117480     -103     
  Branches    18002    17974      -28     
==========================================
+ Hits        54729    54781      +52     
+ Misses      58733    58580     -153     
+ Partials     4121     4119       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

Logo
Checkmarx One – Scan Summary & Detailse4fe5024-3ad0-47c0-be9d-154e2fbd655a

Great job! No new security vulnerabilities introduced in this pull request

@amorask-bitwarden amorask-bitwarden deleted the billing/PM-33473/remove-pm29594-feature-flag branch April 21, 2026 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant