Skip to content

[PM-35318] Desktop v3/4 - Showing two "Archived" badge#20239

Merged
gbubemismith merged 8 commits intomainfrom
vault/PM-35318
Apr 20, 2026
Merged

[PM-35318] Desktop v3/4 - Showing two "Archived" badge#20239
gbubemismith merged 8 commits intomainfrom
vault/PM-35318

Conversation

@gbubemismith
Copy link
Copy Markdown
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-35318

📔 Objective

📸 Screenshots

@gbubemismith gbubemismith marked this pull request as ready for review April 17, 2026 17:25
@gbubemismith gbubemismith requested a review from a team as a code owner April 17, 2026 17:25
shane-melton
shane-melton previously approved these changes Apr 17, 2026
Copy link
Copy Markdown
Member

@shane-melton shane-melton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Looks good!

Image

@gbubemismith gbubemismith enabled auto-merge (squash) April 17, 2026 17:35
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 17, 2026

Codecov Report

❌ Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 46.93%. Comparing base (c73da72) to head (63dbfb0).
⚠️ Report is 3 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...her-view/item-details/item-details-v2.component.ts 90.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20239      +/-   ##
==========================================
+ Coverage   46.76%   46.93%   +0.16%     
==========================================
  Files        3906     3909       +3     
  Lines      118061   118268     +207     
  Branches    18091    18093       +2     
==========================================
+ Hits        55209    55504     +295     
+ Misses      58680    58591      -89     
- Partials     4172     4173       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 17, 2026

Logo
Checkmarx One – Scan Summary & Detailsf45769b9-70da-42e8-9ae6-10430f3848cc


New Issues (1) Checkmarx found the following issues in this Pull Request
# Severity Issue Source File / Package Checkmarx Insight
1 MEDIUM Missing_HSTS_Header apps/browser/src/dirt/phishing-detection/services/phishing-data.service.ts: 304
detailsThe web-application does not define an HSTS header, leaving it vulnerable to attack.
Attack Vector

shane-melton
shane-melton previously approved these changes Apr 17, 2026
@sonarqubecloud
Copy link
Copy Markdown

@gbubemismith gbubemismith merged commit f7475d8 into main Apr 20, 2026
126 checks passed
@gbubemismith gbubemismith deleted the vault/PM-35318 branch April 20, 2026 14:46
gbubemismith added a commit that referenced this pull request Apr 20, 2026
gbubemismith added a commit that referenced this pull request Apr 20, 2026
jaasen-livefront pushed a commit that referenced this pull request Apr 22, 2026
@djsmith85 djsmith85 added the cli CLI Application label May 6, 2026
@djsmith85 djsmith85 added browser Browser Extension desktop Desktop Application web t:bugfix Change Type - Bugfix and removed cli CLI Application labels May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

browser Browser Extension desktop Desktop Application t:bugfix Change Type - Bugfix web

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants