[PM-34195]Apply readonly guards on autofill

[dan-livefront]

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-34195

📔 Objective

Applying the same guards implemented on https://bitwarden.atlassian.net/browse/PM-33431 while cleaning up the isReadonlyOrDisabledFormFieldElement function.

[github-actions]

Bitwarden Claude Code Review

Overall Assessment: APPROVE

This PR extracts the private isReadonlyOrDisabledElement from AutofillOverlayContentService into a shared isReadonlyOrDisabledFormFieldElement utility and reuses it in InsertAutofillContentService.insertValueIntoField, adding the missing aria-readonly guard at the insertion call site (PM-34195). The refactor improves type safety by replacing casts with proper type guards (elementIsInputElement/elementIsTextAreaElement) before accessing readOnly, introduces an AutofillFieldReadonlyDisabledState Pick type for cached metadata, and includes targeted unit tests for both the new utility and the new aria-readonly skip behavior.

Behavior was traced across both call sites: the previous (elementCanBeFilled && element.disabled) skip for <select disabled> is preserved because getPropertyOrAttribute reads the disabled property first, and the aria-readonly check correctly uses checkString=true so only the literal string "true" triggers.

Code Review Details

No findings.

[codecov]

Codecov Report

❌ Patch coverage is 69.23077% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.03%. Comparing base (c9005d6) to head (dc887e9).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...ofill/services/autofill-overlay-content.service.ts	20.00%	0 Missing and 4 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #20237      +/-   ##
==========================================
- Coverage   47.03%   47.03%   -0.01%     
==========================================
  Files        3921     3921              
  Lines      118499   118499              
  Branches    18130    18128       -2     
==========================================
- Hits        55737    55733       -4     
- Misses      58575    58579       +4     
  Partials     4187     4187              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

Checkmarx One – Scan Summary & Details – 4e2974fd-bdb0-46d9-ae9e-47e389862d2d

Great job! No new security vulnerabilities introduced in this pull request

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[bw-ghapp]

Changes in this PR impact the Autofill experience of the browser client

BIT has tested the core experience with these changes and the feature flag configuration used by vault.bitwarden.com.

✅ Fortunately, these BIT tests have passed! 🎉

[bw-ghapp]

Changes in this PR impact the Autofill experience of the browser client

BIT has tested the core experience with these changes and all feature flags disabled.

✅ Fortunately, these BIT tests have passed! 🎉