Skip to content

Migrate client specific skills into correct location#20233

Merged
theMickster merged 1 commit intomainfrom
migrate-client-skills
Apr 21, 2026
Merged

Migrate client specific skills into correct location#20233
theMickster merged 1 commit intomainfrom
migrate-client-skills

Conversation

@theMickster
Copy link
Copy Markdown
Contributor

🎟️ Tracking

PM-35296

📔 Objective

Migrate the client specific skill out of the bitwarden-software-engineer.
The skill has a minor alteration to the description frontmatter to remove obvious wording from the Use when sentence.
The skill no longer has a Repository Orientation section because that's incorrect for a skill to contain.

@theMickster theMickster requested a review from a team as a code owner April 17, 2026 14:25
@theMickster theMickster added the ai-review Request a Claude code review label Apr 17, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 17, 2026

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

This PR migrates the writing-client-code skill from the external bitwarden-software-engineer plugin into the clients repository at .claude/skills/writing-client-code/SKILL.md. The change is documentation-only, adding a 105-line skill file that codifies Angular and TypeScript conventions for the Bitwarden clients monorepo. The content is consistent with existing project instructions in CLAUDE.md and covers architectural rationale, critical rules for new code, and examples.

No findings were identified.

@sonarqubecloud
Copy link
Copy Markdown

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.12%. Comparing base (7a01b76) to head (69b49bb).
⚠️ Report is 54 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20233      +/-   ##
==========================================
- Coverage   47.12%   47.12%   -0.01%     
==========================================
  Files        3898     3898              
  Lines      117576   117576              
  Branches    18000    18000              
==========================================
- Hits        55412    55410       -2     
- Misses      59666    59668       +2     
  Partials     2498     2498              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

Logo
Checkmarx One – Scan Summary & Detailsfc675bcf-7a59-4ee0-b7c9-9134439dc9f8

Great job! No new security vulnerabilities introduced in this pull request

Copy link
Copy Markdown
Contributor

@SaintPatrck SaintPatrck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌱 Let's make sure to update allowed-tools in a follow-up PR.

@theMickster
Copy link
Copy Markdown
Contributor Author

🌱 Let's make sure to update allowed-tools in a follow-up PR.

Let's chat about it. I don't think I want to have it in there just yet, but, instead, have another heading called ## Sources that is used by Claude during skill development/refinement/improvement to validate that the information found in the skill still matches the information in Contributing Docs.

I am working on this locally with my local user-level CLAUDE.md files. I'll let you know when/if that's ready for a primetime promotion.

@theMickster theMickster merged commit 471897d into main Apr 21, 2026
51 checks passed
@theMickster theMickster deleted the migrate-client-skills branch April 21, 2026 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants