Skip to content

[PM-35253] Add organization ability UseInviteLinks#20227

Merged
r-tome merged 9 commits intomainfrom
ac/pm-35253/add-useinvitelinks-organization-ability
Apr 30, 2026
Merged

[PM-35253] Add organization ability UseInviteLinks#20227
r-tome merged 9 commits intomainfrom
ac/pm-35253/add-useinvitelinks-organization-ability

Conversation

@r-tome
Copy link
Copy Markdown
Contributor

@r-tome r-tome commented Apr 17, 2026

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-35253

📔 Objective

Add the new organization ability UseInviteLinks to the shared clients models (organization + plan responses).

Related Pricing Service changes: https://github.com/bitwarden/billing-pricing/pull/103
Related Server changes: bitwarden/server#7489

@r-tome r-tome added the ai-review-vnext Request a Claude code review using the vNext workflow label Apr 17, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 17, 2026

Bitwarden Claude Code Review

Overall Assessment: APPROVE

This PR adds the UseInviteLinks organization ability and the corresponding HasInviteLinks plan property to the shared client models. The field is propagated additively through OrganizationResponse, ProfileOrganizationResponse, PlanResponse, OrganizationData, and the Organization domain model, with the test fixture in organization.data.spec.ts updated to match. The implementation mirrors the established pattern used by sibling abilities (useMyItems, usePhishingBlocker), including the ?? false backward-compatibility fallback at the response deserialization layer.

Code Review Details

No findings.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 17, 2026

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.10%. Comparing base (c10e581) to head (674cfc7).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...n-console/models/response/organization.response.ts 0.00% 1 Missing ⚠️
...ommon/src/billing/models/response/plan.response.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #20227   +/-   ##
=======================================
  Coverage   47.10%   47.10%           
=======================================
  Files        3941     3941           
  Lines      119679   119681    +2     
  Branches    18369    18371    +2     
=======================================
+ Hits        56378    56379    +1     
- Misses      59031    59033    +2     
+ Partials     4270     4269    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 17, 2026

Logo
Checkmarx One – Scan Summary & Detailsd2ab0a60-63fe-4790-9bf4-d4dbc36601c7


New Issues (1) Checkmarx found the following issues in this Pull Request
# Severity Issue Source File / Package Checkmarx Insight
1 MEDIUM Missing_HSTS_Header apps/browser/src/dirt/phishing-detection/services/phishing-data.service.ts: 305
detailsThe web-application does not define an HSTS header, leaving it vulnerable to attack.
Attack Vector

@r-tome r-tome marked this pull request as ready for review April 17, 2026 13:33
@r-tome r-tome requested review from a team as code owners April 17, 2026 13:33
@r-tome r-tome added the needs-qa Marks a PR as requiring QA approval label Apr 17, 2026
@r-tome r-tome removed needs-qa Marks a PR as requiring QA approval ai-review-vnext Request a Claude code review using the vNext workflow labels Apr 29, 2026
@sonarqubecloud
Copy link
Copy Markdown

@r-tome r-tome merged commit 14e9b6a into main Apr 30, 2026
166 of 167 checks passed
@r-tome r-tome deleted the ac/pm-35253/add-useinvitelinks-organization-ability branch April 30, 2026 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants