Skip to content

Remove masterkey state#20222

Draft
quexten wants to merge 2 commits intomainfrom
km/remove-masterkey-state
Draft

Remove masterkey state#20222
quexten wants to merge 2 commits intomainfrom
km/remove-masterkey-state

Conversation

@quexten
Copy link
Copy Markdown
Contributor

@quexten quexten commented Apr 17, 2026

🎟️ Tracking

📔 Objective

Removes master-key state, double KDF derivation, and the old login method implementations. This speeds up unlock.

📸 Screenshots

@quexten quexten added the ai-review Request a Claude code review label Apr 17, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 17, 2026

Logo
Checkmarx One – Scan Summary & Details3a4fb315-3d57-4c82-8bde-0e364df5685b


New Issues (4) Checkmarx found the following issues in this Pull Request
# Severity Issue Source File / Package Checkmarx Insight
1 HIGH CVE-2026-2359 Npm-multer-2.0.2
detailsRecommended version: 2.1.1
Description: Multer is a node.js middleware for handling `multipart/form-data`. A vulnerability in Multer prior to version 2.1.0 allows an attacker to trigger a...
Attack Vector: NETWORK
Attack Complexity: LOW
Vulnerable Package
2 HIGH CVE-2026-27959 Npm-koa-3.1.1
detailsRecommended version: 3.1.2
Description: Koa is middleware for Node.js using ES2017 async functions. Prior to versions 2.16.4 and 3.x prior to 3.1.2, Koa's `ctx.hostname` API performs naiv...
Attack Vector: NETWORK
Attack Complexity: LOW
Vulnerable Package
3 HIGH CVE-2026-3304 Npm-multer-2.0.2
detailsRecommended version: 2.1.1
Description: Multer is a node.js middleware for handling `multipart/form-data`. A vulnerability in Multer prior to version 2.1.0 and 3.0.0-alpha1 allows an att...
Attack Vector: NETWORK
Attack Complexity: LOW
Vulnerable Package
4 HIGH CVE-2026-3520 Npm-multer-2.0.2
detailsRecommended version: 2.1.1
Description: Multer is a node.js middleware for handling `multipart/form-data`. A vulnerability in Multer prior to version 2.1.1 allows an attacker to trigger a...
Attack Vector: NETWORK
Attack Complexity: LOW
Vulnerable Package

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 17, 2026

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

This PR removes legacy master key state, double KDF derivation, and old login method implementations (~1000 lines deleted). It eliminates three feature flags (UseUnlockServiceForPasswordLogin, UnlockKeyConnectorWithSdk, SdkKeyConnectorMigration) that gated the SDK-based unlock transition, making the new unlock paths the sole implementation. The removal is thorough — no dangling references to removed APIs remain in non-test production code.

Code Review Details
  • 🎨 : Unused MASTER_PASSWORD_MEMORY import remains after MASTER_KEY state definition was removed — likely contributing to lint CI failure
    • libs/common/src/key-management/master-password/services/master-password.service.ts:20

@sonarqubecloud
Copy link
Copy Markdown

@bw-ghapp
Copy link
Copy Markdown
Contributor

bw-ghapp bot commented Apr 17, 2026

Changes in this PR impact the Autofill experience of the browser client

BIT has tested the core experience with these changes and all feature flags disabled.

✅ Fortunately, these BIT tests have passed! 🎉

@bw-ghapp
Copy link
Copy Markdown
Contributor

bw-ghapp bot commented Apr 17, 2026

Changes in this PR impact the Autofill experience of the browser client

BIT has tested the core experience with these changes and the feature flag configuration used by vault.bitwarden.com.

✅ Fortunately, these BIT tests have passed! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant