[PM-35290] feat: auto-prefix https:// and improve validation UX for self-hosted environment URLs#20216
Open
sander-adamse wants to merge 3 commits intobitwarden:mainfrom
Open
Conversation
|
Thank you for your contribution! We've added this to our internal tracking system for review. Details on our contribution process can be found here: https://contributing.bitwarden.com/contributing/pull-requests/community-pr-process. |
bitwarden-bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
Users in our pilot kept running into issues setting up the self-hosted environment, because they forgot to include
https://.📔 Objective
The
https://prefix is basically always required for self-hosted setups, so having users type it manually just adds friction. When you type a bare domain likepasswords.company.com, the validator fires immediately telling you to useHTTPS— but that's exactly what it's going to be anyway. Updated the validator to only show an error whenhttp://is explicitly typed, and added auto-prefixing on save so the protocol gets added automatically if it's missing.📸 Screenshots
Input
Output