[PM-35288] feat: auto-close sso tab after authentication completes#20213
Open
sander-adamse wants to merge 1 commit intobitwarden:mainfrom
Open
[PM-35288] feat: auto-close sso tab after authentication completes#20213sander-adamse wants to merge 1 commit intobitwarden:mainfrom
sander-adamse wants to merge 1 commit intobitwarden:mainfrom
Conversation
|
Thank you for your contribution! We've added this to our internal Community PR board for review. Details on our contribution process can be found here: https://contributing.bitwarden.com/contributing/pull-requests/community-pr-process. |
bitwarden-bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
Running a pilot with a few hundred users — most of them find the extra browser tab that stays open after SSO really annoying.
📔 Objective
After SSO login, the tab that opens for authentication stays open with a message telling you to close it yourself. That's unnecessary friction. This PR makes the extension close that tab automatically once it has the auth result, so users don't have to deal with it.
Moved the
authResulthandler fromprocessMessagetoprocessMessageWithSenderto get access to the sender's tab ID, then callBrowserApi.closeTabafter the SSO result popout opens.