Conversation
jest is a transient dependency of ts-jest but because angular-devkit/build-angular drags in an older version of jest, we have to add jest 30.3.0 to our dependencies
|
New Issues (1)Checkmarx found the following issues in this Pull Request
Fixed Issues (5)Great job! The following issues were fixed in this Pull Request
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #20211 +/- ##
==========================================
- Coverage 47.12% 46.54% -0.59%
==========================================
Files 3898 3898
Lines 117576 117576
Branches 18000 18000
==========================================
- Hits 55412 54726 -686
+ Misses 59666 58732 -934
- Partials 2498 4118 +1620 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Changes in this PR impact the Autofill experience of the browser clientBIT has tested the core experience with these changes and the feature flag configuration used by ✅ Fortunately, these BIT tests have passed! 🎉 |
Changes in this PR impact the Autofill experience of the browser clientBIT has tested the core experience with these changes and all feature flags disabled. ✅ Fortunately, these BIT tests have passed! 🎉 |
cd-bitwarden
left a comment
There was a problem hiding this comment.
Thanks Daniel, these changes look great!
jprusik
left a comment
There was a problem hiding this comment.
Approved for Autofill concerns







🎟️ Tracking
https://bitwarden.atlassian.net/browse/SM-1762
📔 Objective
Update Jest to the new major version 30.3.0
With #19981 the first attempt was made, but it did include a larger change-set than needed and skipped some test cases. This aims to break it up and in case some of the additional changes are needed with another bump of jest-environment-jsdom, we can revisit that PR after this merges into main.,
This PR bumps all required dependencies around Jest and fixes any broken paths or tests due to stricter typescript rules with jest-environment-jsdom (mainly mockImplementation)
Relates to:
#17623
#20202
#19843