Skip to content

[SM-1762] Bump Jest to 30.3.0#20211

Merged
djsmith85 merged 7 commits intomainfrom
jest-update-djsmith
Apr 17, 2026
Merged

[SM-1762] Bump Jest to 30.3.0#20211
djsmith85 merged 7 commits intomainfrom
jest-update-djsmith

Conversation

@djsmith85
Copy link
Copy Markdown
Contributor

@djsmith85 djsmith85 commented Apr 16, 2026

🎟️ Tracking

https://bitwarden.atlassian.net/browse/SM-1762

📔 Objective

Update Jest to the new major version 30.3.0

With #19981 the first attempt was made, but it did include a larger change-set than needed and skipped some test cases. This aims to break it up and in case some of the additional changes are needed with another bump of jest-environment-jsdom, we can revisit that PR after this merges into main.,

This PR bumps all required dependencies around Jest and fixes any broken paths or tests due to stricter typescript rules with jest-environment-jsdom (mainly mockImplementation)

Relates to:
#17623
#20202
#19843

jest is a transient dependency of ts-jest but because angular-devkit/build-angular drags in an older version of jest, we have to add jest 30.3.0 to our dependencies
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 16, 2026

Logo
Checkmarx One – Scan Summary & Details0bc0f5bf-da90-4236-9d40-bfa67f2ea77f


New Issues (1) Checkmarx found the following issues in this Pull Request
# Severity Issue Source File / Package Checkmarx Insight
1 MEDIUM Missing_HSTS_Header libs/common/src/services/api.service.ts: 206
detailsThe web-application does not define an HSTS header, leaving it vulnerable to attack.
Attack Vector

Fixed Issues (5) Great job! The following issues were fixed in this Pull Request
Severity Issue Source File / Package
CRITICAL CVE-2026-33937 Npm-handlebars-4.7.8
HIGH CVE-2026-33938 Npm-handlebars-4.7.8
HIGH CVE-2026-33939 Npm-handlebars-4.7.8
HIGH CVE-2026-33940 Npm-handlebars-4.7.8
HIGH CVE-2026-33941 Npm-handlebars-4.7.8

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.54%. Comparing base (7a01b76) to head (ce035d9).
⚠️ Report is 4 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20211      +/-   ##
==========================================
- Coverage   47.12%   46.54%   -0.59%     
==========================================
  Files        3898     3898              
  Lines      117576   117576              
  Branches    18000    18000              
==========================================
- Hits        55412    54726     -686     
+ Misses      59666    58732     -934     
- Partials     2498     4118    +1620     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@djsmith85 djsmith85 changed the title Jest update djsmith [SM-1762] Bump Jest to 30.3.0 Apr 17, 2026
@djsmith85 djsmith85 marked this pull request as ready for review April 17, 2026 14:26
@djsmith85 djsmith85 requested review from a team as code owners April 17, 2026 14:26
@cd-bitwarden cd-bitwarden reopened this Apr 17, 2026
@sonarqubecloud
Copy link
Copy Markdown

@JaredSnider-Bitwarden JaredSnider-Bitwarden removed the request for review from rr-bw April 17, 2026 14:41
@bw-ghapp
Copy link
Copy Markdown
Contributor

bw-ghapp Bot commented Apr 17, 2026

Changes in this PR impact the Autofill experience of the browser client

BIT has tested the core experience with these changes and the feature flag configuration used by vault.bitwarden.com.

✅ Fortunately, these BIT tests have passed! 🎉

@bw-ghapp
Copy link
Copy Markdown
Contributor

bw-ghapp Bot commented Apr 17, 2026

Changes in this PR impact the Autofill experience of the browser client

BIT has tested the core experience with these changes and all feature flags disabled.

✅ Fortunately, these BIT tests have passed! 🎉

Copy link
Copy Markdown
Contributor

@cd-bitwarden cd-bitwarden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Daniel, these changes look great!

Copy link
Copy Markdown
Contributor

@jprusik jprusik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for Autofill concerns

@djsmith85 djsmith85 merged commit dc94f96 into main Apr 17, 2026
167 of 173 checks passed
@djsmith85 djsmith85 deleted the jest-update-djsmith branch April 17, 2026 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants