[CL-1156] Updated breadcrumbs responsive behavior#20207
Draft
lxiong-livefront wants to merge 3 commits intouif/CL-1155/breadcrumb-style-updatesfrom
Draft
[CL-1156] Updated breadcrumbs responsive behavior#20207lxiong-livefront wants to merge 3 commits intouif/CL-1155/breadcrumb-style-updatesfrom
lxiong-livefront wants to merge 3 commits intouif/CL-1155/breadcrumb-style-updatesfrom
Conversation
lxiong-livefront
changed the base branch from
main
to
uif/CL-1155/breadcrumb-style-updates
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## uif/CL-1155/breadcrumb-style-updates #20207 +/- ##
========================================================================
- Coverage 47.06% 47.01% -0.06%
========================================================================
Files 3895 3893 -2
Lines 117441 117406 -35
Branches 17979 17956 -23
========================================================================
- Hits 55277 55196 -81
- Misses 59678 59723 +45
- Partials 2486 2487 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Great job! No new security vulnerabilities introduced in this pull request |
…breadcrumb-responsive-updates
|
| * Excludes the last/active breadcrumb since that is always shown. | ||
| * */ | ||
| protected readonly sortedBreadcrumbs = computed(() => { | ||
| const allBreadcrumbs = this.breadcrumbs().map((_, i) => i); |
Contributor
There was a problem hiding this comment.
I don't really understand the need for this map. What is it we are trying to do here? Just getting a count?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
JIRA
📔 Objective
Added responsive overflow behavior to breadcrumbs
📸 Screenshots
Screen.Recording.2026-04-16.at.12.59.39.PM.mov